<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21462">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Add todos encountered while going through the code<br><br>Change-Id: I8c3a788f008d3cb2d067d974c2b1b9ca45185d8d<br>---<br>M src/gbproxy/gb_proxy.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/21462/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c</span><br><span>index 2c58e80..0d79ff7 100644</span><br><span>--- a/src/gbproxy/gb_proxy.c</span><br><span>+++ b/src/gbproxy/gb_proxy.c</span><br><span>@@ -936,6 +936,7 @@</span><br><span>                                   &ns_bvci, msg);</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: Should we discard this message if the check fails */</span><br><span>        check_peer_nsei(peer, nsei);</span><br><span> </span><br><span>     rc = gbprox_process_bssgp_ul(cfg, msg, peer);</span><br><span>@@ -1390,7 +1391,7 @@</span><br><span>                        LOGP(DGPRS, LOGL_NOTICE, "NSE(%05u/SGSN) BSSGP "</span><br><span>                        "%sBLOCK_ACK for signalling BVCI ?!?\n", nsei,</span><br><span>                             pdu_type == BSSGP_PDUT_BVC_UNBLOCK_ACK ? "UN":"");</span><br><span style="color: hsl(0, 100%, 40%);">-                     /* should we send STATUS ? */</span><br><span style="color: hsl(120, 100%, 40%);">+                 /* TODO: should we send STATUS ? */</span><br><span>                  rate_ctr_inc(&cfg->ctrg-></span><br><span>                               ctr[GBPROX_GLOB_CTR_INV_BVCI]);</span><br><span>                 } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21462">change 21462</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21462"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8c3a788f008d3cb2d067d974c2b1b9ca45185d8d </div>
<div style="display:none"> Gerrit-Change-Number: 21462 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>