<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21444">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">power_control: generalize and rename lchan_ul_pf_ewma()<br><br>This way EWMA based filtering logic can be used not only for<br>MS Power Control, but also for BS Power Control.<br><br>Change-Id: I16c2e1b997f2b8af44d47809420293f072335bbd<br>Related: SYS#4918<br>---<br>M src/common/power_control.c<br>1 file changed, 9 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/21444/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/power_control.c b/src/common/power_control.c</span><br><span>index a20ce55..9d17c89 100644</span><br><span>--- a/src/common/power_control.c</span><br><span>+++ b/src/common/power_control.c</span><br><span>@@ -74,12 +74,12 @@</span><br><span>  *   https://en.wikipedia.org/wiki/Low-pass_filter#Simple_infinite_impulse_response_filter</span><br><span>  *   https://tomroelandts.com/articles/low-pass-single-pole-iir-filter</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-static int8_t lchan_ul_pf_ewma(const struct gsm_bts *bts,</span><br><span style="color: hsl(0, 100%, 40%);">-                         struct gsm_lchan *lchan,</span><br><span style="color: hsl(0, 100%, 40%);">-                        const int8_t Pwr)</span><br><span style="color: hsl(120, 100%, 40%);">+static int8_t do_pf_ewma(const struct bts_power_ctrl_params *params,</span><br><span style="color: hsl(120, 100%, 40%);">+                         struct lchan_power_ctrl_state *state,</span><br><span style="color: hsl(120, 100%, 40%);">+                         const int8_t Pwr)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t A = bts->ul_power_ctrl.pf.ewma.alpha;</span><br><span style="color: hsl(0, 100%, 40%);">-  int *Avg100 = &lchan->ms_power_ctrl.avg100_rxlev_dbm;</span><br><span style="color: hsl(120, 100%, 40%);">+  const uint8_t A = params->pf.ewma.alpha;</span><br><span style="color: hsl(120, 100%, 40%);">+   int *Avg100 = &state->avg100_rxlev_dbm;</span><br><span> </span><br><span>   /* We don't have 'Avg[n - 1]' if this is the first run */</span><br><span>        if (*Avg100 == 0) {</span><br><span>@@ -108,6 +108,9 @@</span><br><span>    int8_t ms_dbm, new_dbm, current_dbm, bsc_max_dbm;</span><br><span>    int8_t avg_ul_rssi_dbm;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   const struct bts_power_ctrl_params *params = &bts->ul_power_ctrl;</span><br><span style="color: hsl(120, 100%, 40%);">+      struct lchan_power_ctrl_state *state = &lchan->ms_power_ctrl;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       if (!trx_ms_pwr_ctrl_is_osmo(trx))</span><br><span>           return 0;</span><br><span>    if (lchan->ms_power_ctrl.fixed)</span><br><span>@@ -131,7 +134,7 @@</span><br><span>     /* Filter UL RSSI to reduce unnecessary Tx power oscillations */</span><br><span>     switch (bts->ul_power_ctrl.pf_algo) {</span><br><span>     case BTS_PF_ALGO_EWMA:</span><br><span style="color: hsl(0, 100%, 40%);">-          avg_ul_rssi_dbm = lchan_ul_pf_ewma(bts, lchan, ul_rssi_dbm);</span><br><span style="color: hsl(120, 100%, 40%);">+          avg_ul_rssi_dbm = do_pf_ewma(params, state, ul_rssi_dbm);</span><br><span>            break;</span><br><span>       case BTS_PF_ALGO_NONE:</span><br><span>       default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21444">change 21444</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21444"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16c2e1b997f2b8af44d47809420293f072335bbd </div>
<div style="display:none"> Gerrit-Change-Number: 21444 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>