<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20927">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">NS2: rework handling of unknown primitive<br><br>Use prim_str() method to get the human readable string.<br>Define unhandled events with a nop in the switch()<br><br>Depends-on: Ibf610fbd929dddc4a4e235152447caff522d4eb2 (libosmocore)<br>Change-Id: I50188afb83ac142e22d4bda4e8050eb4de962e70<br>---<br>M src/gprs_bssgp_pcu.cpp<br>1 file changed, 10 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp</span><br><span>index cb47998..934d8fc 100644</span><br><span>--- a/src/gprs_bssgp_pcu.cpp</span><br><span>+++ b/src/gprs_bssgp_pcu.cpp</span><br><span>@@ -574,11 +574,13 @@</span><br><span>                         the_pcu.bvc_unblocked = 0;</span><br><span>           }</span><br><span>            break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NS_AFF_CAUSE_SNS_FAILURE:</span><br><span style="color: hsl(120, 100%, 40%);">+                break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DPCU, LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-              "NS: %s Unknown prim %d from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DPCU, LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+                     "NS: %s Unknown affecting cause %s / %d from NS\n",</span><br><span>                get_value_string(osmo_prim_op_names, nsp->oph.operation),</span><br><span style="color: hsl(0, 100%, 40%);">-                    nsp->oph.primitive);</span><br><span style="color: hsl(120, 100%, 40%);">+               gprs_ns2_aff_cause_prim_str(nsp->u.status.cause), nsp->u.status.cause);</span><br><span>           break;</span><br><span>       }</span><br><span> }</span><br><span>@@ -613,11 +615,13 @@</span><br><span>       case PRIM_NS_STATUS:</span><br><span>                 gprs_ns_prim_status_cb(nsp);</span><br><span>                 break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case PRIM_NS_CONGESTION:</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DPCU, LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-              "NS: %s Unknown prim %d from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DPCU, LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+                     "NS: %s Unknown prim %s / %d from NS\n",</span><br><span>                   get_value_string(osmo_prim_op_names, oph->operation),</span><br><span style="color: hsl(0, 100%, 40%);">-                oph->primitive);</span><br><span style="color: hsl(120, 100%, 40%);">+                   gprs_ns2_prim_str((gprs_ns2_prim) oph->primitive), oph->primitive);</span><br><span>               break;</span><br><span>       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20927">change 20927</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20927"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I50188afb83ac142e22d4bda4e8050eb4de962e70 </div>
<div style="display:none"> Gerrit-Change-Number: 20927 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>