<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21448">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: properly initialize MS/BS Power Control state<br><br>struct lchan_power_ctrl_state actually contains more fields,<br>which also must be initialized on CHANnel ACTIVation.<br><br>Change-Id: Id9719088fc6e9479c13e9b327a3466d9e2810a3a<br>Related: SYS#4918<br>---<br>M src/common/rsl.c<br>1 file changed, 10 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/21448/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index 2ebfb32..30fa259 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1154,14 +1154,18 @@</span><br><span>              gsm_lchans_name(lchan->state));</span><br><span> </span><br><span>     /* Initialize MS Power Control defaults */</span><br><span style="color: hsl(0, 100%, 40%);">-      lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0);</span><br><span style="color: hsl(0, 100%, 40%);">- lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;</span><br><span style="color: hsl(0, 100%, 40%);">-  lchan->ms_power_ctrl.fixed = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_power_ctrl = (struct lchan_power_ctrl_state) {</span><br><span style="color: hsl(120, 100%, 40%);">+           .max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0),</span><br><span style="color: hsl(120, 100%, 40%);">+              .current = lchan->ms_power_ctrl.max,</span><br><span style="color: hsl(120, 100%, 40%);">+               .fixed = true,</span><br><span style="color: hsl(120, 100%, 40%);">+        };</span><br><span> </span><br><span>       /* Initialize BS Power Control defaults */</span><br><span style="color: hsl(0, 100%, 40%);">-      lchan->bs_power_ctrl.max = 2 * 15;</span><br><span style="color: hsl(0, 100%, 40%);">-   lchan->bs_power_ctrl.current = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-    lchan->bs_power_ctrl.fixed = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->bs_power_ctrl = (struct lchan_power_ctrl_state) {</span><br><span style="color: hsl(120, 100%, 40%);">+           .max = 2 * 15, /* maximum defined in 9.3.4 */</span><br><span style="color: hsl(120, 100%, 40%);">+         .current = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+         .fixed = true,</span><br><span style="color: hsl(120, 100%, 40%);">+        };</span><br><span> </span><br><span>       rsl_tlv_parse(&tp, msgb_l3(msg), msgb_l3len(msg));</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21448">change 21448</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21448"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id9719088fc6e9479c13e9b327a3466d9e2810a3a </div>
<div style="display:none"> Gerrit-Change-Number: 21448 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>