<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21405">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb_proxy: More precise + readable log messages<br><br>* use string representations instead of magic numbers whenever possible<br>* make text actually describe the specific case, rather than copy+paste<br>* proper order order (foobar indication) not (indiocation ..... foobar)<br><br>Change-Id: I232038da26a9963763c5fc9051b87c9182b27d94<br>---<br>M src/gbproxy/gb_proxy.c<br>1 file changed, 7 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/05/21405/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c</span><br><span>index 9009651..b0d1f32 100644</span><br><span>--- a/src/gbproxy/gb_proxy.c</span><br><span>+++ b/src/gbproxy/gb_proxy.c</span><br><span>@@ -1471,10 +1471,8 @@</span><br><span>              LOGP(DPCU, LOGL_NOTICE, "NS-NSE %d became unavailable\n", nsp->nsei);</span><br><span>           break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DPCU, LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-              "NS: %s Unknown prim %d from NS\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                   get_value_string(osmo_prim_op_names, nsp->oph.operation),</span><br><span style="color: hsl(0, 100%, 40%);">-                    nsp->oph.primitive);</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGP(DPCU, LOGL_NOTICE, "NS: Unknown NS-STATUS.ind cause=%s from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  gprs_ns2_aff_cause_prim_str(nsp->u.status.cause));</span><br><span>           break;</span><br><span>       }</span><br><span> }</span><br><span>@@ -1493,9 +1491,8 @@</span><br><span>       nsp = container_of(oph, struct osmo_gprs_ns2_prim, oph);</span><br><span> </span><br><span>         if (oph->operation != PRIM_OP_INDICATION) {</span><br><span style="color: hsl(0, 100%, 40%);">-          LOGP(DPCU, LOGL_NOTICE, "NS: %s Unknown prim %d from NS\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                get_value_string(osmo_prim_op_names, oph->operation),</span><br><span style="color: hsl(0, 100%, 40%);">-                oph->operation);</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DPCU, LOGL_NOTICE, "NS: Unexpected primitive operation %s from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+               get_value_string(osmo_prim_op_names, oph->operation));</span><br><span>               return 0;</span><br><span>    }</span><br><span> </span><br><span>@@ -1513,10 +1510,9 @@</span><br><span>               gprs_ns_prim_status_cb(cfg, nsp);</span><br><span>            break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DPCU, LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-              "NS: %s Unknown prim %d from NS\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                   get_value_string(osmo_prim_op_names, oph->operation),</span><br><span style="color: hsl(0, 100%, 40%);">-                oph->primitive);</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DPCU, LOGL_NOTICE, "NS: Unknown prim %s %s from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+              gprs_ns2_prim_str(oph->primitive),</span><br><span style="color: hsl(120, 100%, 40%);">+                 get_value_string(osmo_prim_op_names, oph->operation));</span><br><span>               break;</span><br><span>       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21405">change 21405</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21405"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I232038da26a9963763c5fc9051b87c9182b27d94 </div>
<div style="display:none"> Gerrit-Change-Number: 21405 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>