<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21401">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Test for sizes up to 1600 bytes, not just 1024 bytes<br><br>The NS specs state up to 1600 bytes "gross NS size" must be supported,<br>at least by the underlying FR layer. Let's test up to that.  Let's<br>also speed things up by using 4-byte size increments, and print<br>the size of the current message.<br><br>Change-Id: I76358323e79cfc3d0e9c979c716b7a552f3b8e3b<br>---<br>M gbproxy/GBProxy_Tests.ttcn<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/21401/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index b708fa0..0721fbd 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -40,6 +40,9 @@</span><br><span> /* mcc_mnc is 24.008 10.5.5.15 encoded. 262 42 */</span><br><span> const BcdMccMnc c_mcc_mnc := '262F42'H;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* 48.016 section 6.1.4.2: The default maximum information field size of 1600 octets shall be supported on the Gb interface */</span><br><span style="color: hsl(120, 100%, 40%);">+const integer max_fr_info_size := 1600;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> modulepar {</span><br><span>       /* IP/port on which we run our internal GSUP/HLR emulation */</span><br><span>        NSConfigurations mp_nsconfig_sgsn := {</span><br><span>@@ -754,12 +757,13 @@</span><br><span>       var BssgpBvcConfig bvcc := g_pars.pcu[ran_idx].cfg.bvc[0];</span><br><span>   var integer i;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      for (i := 0; i < 1024; i := i+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < max_fr_info_size-4; i := i+4) {</span><br><span>          var octetstring payload := f_rnd_octstring(i);</span><br><span>               var template (value) PDU_BSSGP pdu_tx := ts_BSSGP_UL_UD(g_pars.tlli, bvcc.cell_id, payload);</span><br><span>                 /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span>               var template (present) PDU_BSSGP pdu_rx := tr_BSSGP_UL_UD(g_pars.tlli, bvcc.cell_id, payload);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+            log("UL-UNITDATA(payload_size=", i);</span><br><span>               f_pcu2sgsn(pdu_tx, pdu_rx);</span><br><span>  }</span><br><span>    setverdict(pass);</span><br><span>@@ -781,7 +785,7 @@</span><br><span> private function f_TC_dl_unitdata(charstring id) runs on BSSGP_ConnHdlr {</span><br><span>         var integer i;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      for (i := 0; i < 1024; i := i+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < max_fr_info_size-4; i := i+4) {</span><br><span>          var octetstring payload := f_rnd_octstring(i);</span><br><span>               var template (value) PDU_BSSGP pdu_tx :=</span><br><span>                     ts_BSSGP_DL_UD(g_pars.tlli, payload, omit, ts_BSSGP_IMSI(g_pars.imsi));</span><br><span>@@ -789,6 +793,7 @@</span><br><span>                var template (present) PDU_BSSGP pdu_rx :=</span><br><span>                   tr_BSSGP_DL_UD(g_pars.tlli, payload, tr_BSSGP_IMSI(g_pars.imsi));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         log("DL-UNITDATA(payload_size=", i);</span><br><span>               f_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span>  }</span><br><span>    setverdict(pass);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21401">change 21401</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21401"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I76358323e79cfc3d0e9c979c716b7a552f3b8e3b </div>
<div style="display:none"> Gerrit-Change-Number: 21401 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>