<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21325">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Port TC_{suspend,resume} to new GLOBAL port<br><br>With the previous commit, we change the processing of the SUSPEND/RESUME<br>related PDUs and handle them now via a new per-NSE "GLOBAL" port.<br><br>Change-Id: I805372f3024a0ec2491a24422e02c0bc6dc669d2<br>---<br>M gbproxy/GBProxy_Tests.ttcn<br>1 file changed, 96 insertions(+), 38 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index 4f0f8b6..0bafaa0 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -605,6 +605,72 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/***********************************************************************</span><br><span style="color: hsl(120, 100%, 40%);">+ * GlobaLTest_CT: Using the per-NSE GLOBAL ports on PCU + SGSN side</span><br><span style="color: hsl(120, 100%, 40%);">+ ***********************************************************************/</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+type component GlobalTest_CT extends test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ port BSSGP_PT G_PCU[NUM_PCU];</span><br><span style="color: hsl(120, 100%, 40%);">+ port BSSGP_PT G_SGSN[NUM_SGSN];</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_global_init() runs on GlobalTest_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer i;</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < lengthof(g_sgsn); i := i+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ connect(self:G_SGSN[i], g_sgsn[i].vc_BSSGP:GLOBAL);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < lengthof(g_pcu); i := i+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ connect(self:G_PCU[i], g_pcu[i].vc_BSSGP:GLOBAL);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Send 'tx' on PTP-BVCI from PCU; expect 'rx' on SGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_global_pcu2sgsn(template (value) PDU_BSSGP tx, template (present) PDU_BSSGP exp_rx,</span><br><span style="color: hsl(120, 100%, 40%);">+ integer pcu_idx := 0, integer sgsn_idx := 0) runs on GlobalTest_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PDU_BSSGP rx;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 1.0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ G_PCU[pcu_idx].send(tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] G_SGSN[sgsn_idx].receive(exp_rx) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] G_SGSN[sgsn_idx].receive(PDU_BSSGP:?) -> value rx {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected BSSGP on SGSN side: ", rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ", rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Send 'tx' on PTP-BVCI from SGSN; expect 'rx' on PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_global_sgsn2pcu(template (value) PDU_BSSGP tx, template (present) PDU_BSSGP exp_rx,</span><br><span style="color: hsl(120, 100%, 40%);">+ integer sgsn_idx := 0, integer pcu_idx := 0) runs on GlobalTest_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PDU_BSSGP rx;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 1.0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ G_SGSN[sgsn_idx].send(tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] G_PCU[pcu_idx].receive(exp_rx) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] G_PCU[pcu_idx].receive(PDU_BSSGP:?) -> value rx {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected BSSGP on PCU side: ", rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for BSSGP on PCU side: ", rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* TODO:</span><br><span> * Detach without Attach</span><br><span> * SM procedures without attach / RAU</span><br><span>@@ -812,83 +878,75 @@</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_TC_suspend(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_suspend() runs on GlobalTest_CT {</span><br><span> var integer i;</span><br><span> </span><br><span> /* TODO: Generate RA ID for each ConnHdlr */</span><br><span style="color: hsl(0, 100%, 40%);">- var RoutingAreaIdentification ra_id := g_pars.pcu[0].cfg.bvc[0].cell_id.ra_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RoutingAreaIdentification ra_id := g_pcu[0].cfg.bvc[0].cell_id.ra_id;</span><br><span> for (i := 0; i < 10; i := i+1) {</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- var template (value) PDU_BSSGP pdu_tx := ts_BSSGP_SUSPEND(g_pars.tlli, ra_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT4 tlli := f_gprs_tlli_random();</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) PDU_BSSGP pdu_tx := ts_BSSGP_SUSPEND(tlli, ra_id);</span><br><span> /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span style="color: hsl(0, 100%, 40%);">- var template (present) PDU_BSSGP pdu_rx := tr_BSSGP_SUSPEND(g_pars.tlli, ra_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (present) PDU_BSSGP pdu_rx := tr_BSSGP_SUSPEND(tlli, ra_id);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_pcu2sgsn(pdu_tx, pdu_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_pcu2sgsn(pdu_tx, pdu_rx);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- pdu_tx := ts_BSSGP_SUSPEND_ACK(g_pars.tlli, ra_id, int2oct(i, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_tx := ts_BSSGP_SUSPEND_ACK(tlli, ra_id, int2oct(i, 1));</span><br><span> /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span style="color: hsl(0, 100%, 40%);">- pdu_rx := tr_BSSGP_SUSPEND_ACK(g_pars.tlli, ra_id, int2oct(i, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_rx := tr_BSSGP_SUSPEND_ACK(tlli, ra_id, int2oct(i, 1));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span> </span><br><span> /* These messages are simple passed through so just also test sending NACK */</span><br><span style="color: hsl(0, 100%, 40%);">- pdu_tx := ts_BSSGP_SUSPEND_NACK(g_pars.tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_tx := ts_BSSGP_SUSPEND_NACK(tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span> /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span style="color: hsl(0, 100%, 40%);">- pdu_rx := tr_BSSGP_SUSPEND_NACK(g_pars.tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_rx := tr_BSSGP_SUSPEND_NACK(tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span> }</span><br><span> setverdict(pass);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-testcase TC_suspend() runs on test_CT</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_suspend() runs on GlobalTest_CT</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- var BSSGP_ConnHdlr vc_conn;</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn := f_start_handler(refers(f_TC_suspend), testcasename(), g_pcu, g_sgsn, 6);</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn.done;</span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_TC_suspend();</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_TC_resume(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_resume() runs on GlobalTest_CT {</span><br><span> var integer i;</span><br><span> </span><br><span> /* TODO: Generate RA ID for each ConnHdlr */</span><br><span style="color: hsl(0, 100%, 40%);">- var RoutingAreaIdentification ra_id := g_pars.pcu[0].cfg.bvc[0].cell_id.ra_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RoutingAreaIdentification ra_id := g_pcu[0].cfg.bvc[0].cell_id.ra_id;</span><br><span> for (i := 0; i < 10; i := i+1) {</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- var template (value) PDU_BSSGP pdu_tx := ts_BSSGP_RESUME(g_pars.tlli, ra_id, int2oct(i, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT4 tlli := f_gprs_tlli_random();</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) PDU_BSSGP pdu_tx := ts_BSSGP_RESUME(tlli, ra_id, int2oct(i, 1));</span><br><span> /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span style="color: hsl(0, 100%, 40%);">- var template (present) PDU_BSSGP pdu_rx := tr_BSSGP_RESUME(g_pars.tlli, ra_id, int2oct(i, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (present) PDU_BSSGP pdu_rx := tr_BSSGP_RESUME(tlli, ra_id, int2oct(i, 1));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_pcu2sgsn(pdu_tx, pdu_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_pcu2sgsn(pdu_tx, pdu_rx);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- pdu_tx := ts_BSSGP_RESUME_ACK(g_pars.tlli, ra_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_tx := ts_BSSGP_RESUME_ACK(tlli, ra_id);</span><br><span> /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span style="color: hsl(0, 100%, 40%);">- pdu_rx := tr_BSSGP_RESUME_ACK(g_pars.tlli, ra_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_rx := tr_BSSGP_RESUME_ACK(tlli, ra_id);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span> </span><br><span> /* These messages are simple passed through so just also test sending NACK */</span><br><span style="color: hsl(0, 100%, 40%);">- pdu_tx := ts_BSSGP_RESUME_NACK(g_pars.tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_tx := ts_BSSGP_RESUME_NACK(tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span> /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span style="color: hsl(0, 100%, 40%);">- pdu_rx := tr_BSSGP_RESUME_NACK(g_pars.tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu_rx := tr_BSSGP_RESUME_NACK(tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span> }</span><br><span> setverdict(pass);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-testcase TC_resume() runs on test_CT</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_resume() runs on GlobalTest_CT</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- var BSSGP_ConnHdlr vc_conn;</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn := f_start_handler(refers(f_TC_resume), testcasename(), g_pcu, g_sgsn, 6);</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn.done;</span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ f_global_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_TC_resume();</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21325">change 21325</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21325"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I805372f3024a0ec2491a24422e02c0bc6dc669d2 </div>
<div style="display:none"> Gerrit-Change-Number: 21325 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>