<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c">File src/gb/frame_relay.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@106">Patch Set #1, Line 106:</a> <code style="font-family:monospace,monospace">/* RX Message: 14 [ 00 01 03 08 00 75 95 01 01 00 03 02 01 00 ] */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">what's bad about some examples of the messages in a comment?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">well I'd expect then at least some comment explaining what these list of bytes mean, or to which kind of message / layer they belong.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@343">Patch Set #1, Line 343:</a> <code style="font-family:monospace,monospace"> /* TODO: implement FRNET free */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">it's complicated ;D. See the new big comment.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't see a new big comment in here in new patch version.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243/2/src/gb/frame_relay.c">File src/gb/frame_relay.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243/2/src/gb/frame_relay.c@345">Patch Set #2, Line 345:</a> <code style="font-family:monospace,monospace"> LOGPFRL(link, LOGL_ERROR, "STATUS-ENQ are not support for role user\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">you missed the "support"->"supported" part.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243/2/src/gb/frame_relay.c@948">Patch Set #2, Line 948:</a> <code style="font-family:monospace,monospace">/* TODO: rework osmo_fr_dlc_alloc/free with handling it's own memory.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is the big new comment?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21243/2/src/gb/frame_relay.c@953">Patch Set #2, Line 953:</a> <code style="font-family:monospace,monospace"> * by the frame relay because the network is configuring the dlc.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I guess this is where you want to use the API include/osmocom/core/use_count.h</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21243">change 21243</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21243"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id3b49f93d33c271f77cd9c9db03cde6b727a4d30 </div>
<div style="display:none"> Gerrit-Change-Number: 21243 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 24 Nov 2020 10:37:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>