<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21309">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb_proxy: Properly implement paging to LAC/RAC<br><br>There may very well be many PCUs connected within the same RAC or LAC.<br><br>This means we'll need to iterate the list of peers and dispatch it to<br>each matching peer.<br><br>Change-Id: I2c44959661fb53730586f4347cbfbbcece065e13<br>---<br>M src/gbproxy/gb_proxy.c<br>1 file changed, 29 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/09/21309/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c</span><br><span>index fb58284..6c56233 100644</span><br><span>--- a/src/gbproxy/gb_proxy.c</span><br><span>+++ b/src/gbproxy/gb_proxy.c</span><br><span>@@ -1098,37 +1098,54 @@</span><br><span> static int gbprox_rx_paging(struct gbproxy_config *cfg, struct msgb *msg, struct tlv_parsed *tp,</span><br><span> uint32_t nsei, uint16_t ns_bvci)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- struct gbproxy_peer *peer = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gbproxy_peer *peer;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int n_peers = 0;</span><br><span> int errctr = GBPROX_GLOB_CTR_PROTO_ERR_SGSN;</span><br><span> </span><br><span> LOGP(DGPRS, LOGL_INFO, "NSEI=%u(SGSN) BSSGP PAGING ",</span><br><span> nsei);</span><br><span> if (TLVP_PRESENT(tp, BSSGP_IE_BVCI)) {</span><br><span> uint16_t bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));</span><br><span style="color: hsl(0, 100%, 40%);">- peer = gbproxy_peer_by_bvci(cfg, bvci);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DGPRS, LOGL_INFO, "routing by BVCI to peer BVCI=%u\n",</span><br><span style="color: hsl(0, 100%, 40%);">- bvci);</span><br><span> errctr = GBPROX_GLOB_CTR_OTHER_ERR;</span><br><span style="color: hsl(120, 100%, 40%);">+ peer = gbproxy_peer_by_bvci(cfg, bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DGPRS, LOGL_INFO, "routing by BVCI to peer BVCI=%u\n", bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!peer) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGPRS, LOGL_NOTICE, "NSEI=%u(SGSN) BSSGP PAGING: "</span><br><span style="color: hsl(120, 100%, 40%);">+ "unable to route: BVCI=%u unknown\n", nsei, bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&cfg->ctrg->ctr[errctr]);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return gbprox_relay2peer(msg, peer, ns_bvci);</span><br><span> } else if (TLVP_PRESENT(tp, BSSGP_IE_ROUTEING_AREA)) {</span><br><span style="color: hsl(0, 100%, 40%);">- peer = gbproxy_peer_by_rai(cfg, TLVP_VAL(tp, BSSGP_IE_ROUTEING_AREA));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DGPRS, LOGL_INFO, "routing by RAI to peer BVCI=%u\n",</span><br><span style="color: hsl(0, 100%, 40%);">- peer ? peer->bvci : -1);</span><br><span> errctr = GBPROX_GLOB_CTR_INV_RAI;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* iterate over all peers and dispatch the paging to each matching one */</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(peer, &cfg->bts_peers, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!memcmp(peer->ra, TLVP_VAL(tp, BSSGP_IE_ROUTEING_AREA), 6)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DGPRS, LOGL_INFO, "routing by RAI to peer BVCI=%u\n", peer->bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ gbprox_relay2peer(msg, peer, ns_bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ n_peers++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> } else if (TLVP_PRESENT(tp, BSSGP_IE_LOCATION_AREA)) {</span><br><span style="color: hsl(0, 100%, 40%);">- peer = gbproxy_peer_by_lai(cfg, TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DGPRS, LOGL_INFO, "routing by LAI to peer BVCI=%u\n",</span><br><span style="color: hsl(0, 100%, 40%);">- peer ? peer->bvci : -1);</span><br><span> errctr = GBPROX_GLOB_CTR_INV_LAI;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* iterate over all peers and dispatch the paging to each matching one */</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(peer, &cfg->bts_peers, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!memcmp(peer->ra, TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA), 5)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DGPRS, LOGL_INFO, "routing by LAI to peer BVCI=%u\n", peer->bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ gbprox_relay2peer(msg, peer, ns_bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ n_peers++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> } else</span><br><span> LOGPC(DGPRS, LOGL_INFO, "\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!peer) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (n_peers == 0) {</span><br><span> LOGP(DGPRS, LOGL_ERROR, "NSEI=%u(SGSN) BSSGP PAGING: "</span><br><span> "unable to route, missing IE\n", nsei);</span><br><span> rate_ctr_inc(&cfg->ctrg->ctr[errctr]);</span><br><span> return -EINVAL;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- return gbprox_relay2peer(msg, peer, ns_bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span> }</span><br><span> </span><br><span> /* Receive an incoming BVC-RESET message from the SGSN */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21309">change 21309</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21309"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2c44959661fb53730586f4347cbfbbcece065e13 </div>
<div style="display:none"> Gerrit-Change-Number: 21309 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>