<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21312">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb_proxy_peer: Add some FIXMEs regarding invalid assumptions<br><br>Change-Id: Ibf3d4a3bd58e706dfa44e8cc9ff4823a7759dea5<br>---<br>M src/gbproxy/gb_proxy_peer.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/12/21312/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c</span><br><span>index 48482b6..cb76a59 100644</span><br><span>--- a/src/gbproxy/gb_proxy_peer.c</span><br><span>+++ b/src/gbproxy/gb_proxy_peer.c</span><br><span>@@ -105,6 +105,7 @@</span><br><span> }</span><br><span> </span><br><span> /* look-up a peer by its Routeing Area Identification (RAI) */</span><br><span style="color: hsl(120, 100%, 40%);">+/* FIXME: this doesn't make sense, as RA can span multiple peers! */</span><br><span> struct gbproxy_peer *gbproxy_peer_by_rai(struct gbproxy_config *cfg,</span><br><span>                                    const uint8_t *ra)</span><br><span> {</span><br><span>@@ -117,6 +118,7 @@</span><br><span> }</span><br><span> </span><br><span> /* look-up a peer by its Location Area Identification (LAI) */</span><br><span style="color: hsl(120, 100%, 40%);">+/* FIXME: this doesn't make sense, as LA can span multiple peers! */</span><br><span> struct gbproxy_peer *gbproxy_peer_by_lai(struct gbproxy_config *cfg,</span><br><span>                                   const uint8_t *la)</span><br><span> {</span><br><span>@@ -129,6 +131,7 @@</span><br><span> }</span><br><span> </span><br><span> /* look-up a peer by its Location Area Code (LAC) */</span><br><span style="color: hsl(120, 100%, 40%);">+/* FIXME: this doesn't make sense, as LAC can span multiple peers! */</span><br><span> struct gbproxy_peer *gbproxy_peer_by_lac(struct gbproxy_config *cfg,</span><br><span>                                    const uint8_t *la)</span><br><span> {</span><br><span>@@ -151,6 +154,7 @@</span><br><span>                       return gbproxy_peer_by_bvci(cfg, bvci);</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: this doesn't make sense, as RA can span multiple peers! */</span><br><span>     if (TLVP_PRESENT(tp, BSSGP_IE_ROUTEING_AREA)) {</span><br><span>              uint8_t *rai = (uint8_t *)TLVP_VAL(tp, BSSGP_IE_ROUTEING_AREA);</span><br><span>              /* Only compare LAC part, since MCC/MNC are possibly patched.</span><br><span>@@ -159,6 +163,7 @@</span><br><span>          return gbproxy_peer_by_lac(cfg, rai);</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: this doesn't make sense, as LA can span multiple peers! */</span><br><span>     if (TLVP_PRESENT(tp, BSSGP_IE_LOCATION_AREA)) {</span><br><span>              uint8_t *lai = (uint8_t *)TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA);</span><br><span>              return gbproxy_peer_by_lac(cfg, lai);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21312">change 21312</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21312"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibf3d4a3bd58e706dfa44e8cc9ff4823a7759dea5 </div>
<div style="display:none"> Gerrit-Change-Number: 21312 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>