<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21281">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess: Fix log error printed on wrong conditional branch<br><br>The signal link is set if fd is established (see osmo_fd_setup in<br>ipaccess.c).<br><br>This log message was introduced in 466c5467e2e95c04260cb6b933181a38d1d97bd5,<br>where the lifecycle worked a bit different than nowadays:<br>line->ops->sign_link_down() was called before the log line, so the code<br>expected by that time that the socket should have been freed by<br>sign_link_down(). That's no longer the case. In ipaccess_drop, we force<br>dropping so we release lower layers and then signal upper layers. Hence,<br>the log lines are misleading nowadays.<br><br>Change-Id: Ibc6554e6cacc9c71232238b4e6a17d749dfdd30a<br>---<br>M src/input/ipaccess.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/81/21281/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index 593f9f0..48a427c 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -88,8 +88,7 @@</span><br><span> </span><br><span>        /* Error case: we did not see any ID_RESP yet for this socket. */</span><br><span>    if (bfd->fd != -1) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGP(DLINP, LOGL_ERROR, "Forcing socket shutdown with "</span><br><span style="color: hsl(0, 100%, 40%);">-                                       "no signal link set\n");</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, "Forcing socket shutdown\n");</span><br><span>          osmo_fd_unregister(bfd);</span><br><span>             close(bfd->fd);</span><br><span>           bfd->fd = -1;</span><br><span>@@ -101,6 +100,9 @@</span><br><span>               e1inp_line_put2(line, "ipa_bfd");</span><br><span> </span><br><span>              ret = -ENOENT;</span><br><span style="color: hsl(120, 100%, 40%);">+        } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGPITS(e1i_ts, DLINP, LOGL_ERROR,</span><br><span style="color: hsl(120, 100%, 40%);">+                    "Forcing socket shutdown with no signal link set\n");</span><br><span>      }</span><br><span> </span><br><span>        msgb_free(e1i_ts->pending_msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21281">change 21281</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/21281"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibc6554e6cacc9c71232238b4e6a17d749dfdd30a </div>
<div style="display:none"> Gerrit-Change-Number: 21281 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>