<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1//COMMIT_MSG@11">Patch Set #1, Line 11:</a> <code style="font-family:monospace,monospace">ssh instances are running on a single mashine.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">machine</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/process.py">File src/osmo_gsm_tester/core/process.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/process.py@408">Patch Set #1, Line 408:</a> <code style="font-family:monospace,monospace">        # If remote_port is set the command will be executed over ssh on the Android UE.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Drop this comment</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/remote.py">File src/osmo_gsm_tester/core/remote.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/remote.py@54">Patch Set #1, Line 54:</a> <code style="font-family:monospace,monospace">    def RemoteProcess(self, name, popen_args, remote_env={}, remote_port=None, **popen_kwargs):</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Rather move this remote_port to RemoteHost class above like the other parameters.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py">File src/osmo_gsm_tester/obj/run_node.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace">        self._remote_port = remote_port</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ssh_port</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py@59">Patch Set #1, Line 59:</a> <code style="font-family:monospace,monospace">                   conf.get('run_label', None), conf.get('remote_port', None))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ssh_port</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py@94">Patch Set #1, Line 94:</a> <code style="font-family:monospace,monospace">    def remote_port(self):</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ssh_port</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300">change 21300</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2c93fd2ea1c10c333d00eafd3c1066c35796e398 </div>
<div style="display:none"> Gerrit-Change-Number: 21300 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ninjab3s <nils.fuerste@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 23 Nov 2020 19:45:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>