<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21276">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">part 3 of: fix SAPIs for handover, osmo-bts-trx<br><br>Change-Id: I0b34855f0374e9ee7071ce14c1472eb3ead50970<br>---<br>M src/common/scheduler.c<br>M src/osmo-bts-trx/l1_if.c<br>2 files changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/76/21276/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index b61330d..d959eb0 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -858,6 +858,12 @@</span><br><span>           return -ENODEV;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* For handover detection, there are cases where the SACCH should remain inactive until the first RACH</span><br><span style="color: hsl(120, 100%, 40%);">+         * indicating the TA is received. */</span><br><span style="color: hsl(120, 100%, 40%);">+  if (L1SAP_IS_LINK_SACCH(link_id)</span><br><span style="color: hsl(120, 100%, 40%);">+          && !l1t->ts[tn].chan_state[chan].lchan->dl_sacch.activated)</span><br><span style="color: hsl(120, 100%, 40%);">+         return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn,</span><br><span>          "PH-RTS.ind: chan_nr=0x%02x link_id=0x%02x\n", chan_nr, link_id);</span><br><span> </span><br><span>diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c</span><br><span>index fc8ef76..21445da 100644</span><br><span>--- a/src/osmo-bts-trx/l1_if.c</span><br><span>+++ b/src/osmo-bts-trx/l1_if.c</span><br><span>@@ -439,6 +439,10 @@</span><br><span>          case PRIM_INFO_MODIFY:</span><br><span>                       chan_nr = l1sap->u.info.u.act_req.chan_nr;</span><br><span>                        lchan = get_lchan_by_chan_nr(trx, chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* For osmo-bts-trx, the dl_sacch.activated directly has the effect of transmitting the SACCH,</span><br><span style="color: hsl(120, 100%, 40%);">+                         * no need to interact with another entity to activate the SAPI. Just set it to whatever the</span><br><span style="color: hsl(120, 100%, 40%);">+                   * caller wants. */</span><br><span style="color: hsl(120, 100%, 40%);">+                   lchan->dl_sacch.activated = lchan->dl_sacch.want_active;</span><br><span>                       if (l1sap->u.info.type == PRIM_INFO_ACTIVATE) {</span><br><span>                           if ((chan_nr & 0xE0) == 0x80) {</span><br><span>                                  LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "Cannot activate"</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21276">change 21276</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21276"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b34855f0374e9ee7071ce14c1472eb3ead50970 </div>
<div style="display:none"> Gerrit-Change-Number: 21276 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>