<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21202">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_test: add test 31: TCH/H: re-use dyn TS<br><br>Show undesired behavior of opening up another TCH/H timeslot even though<br>another TCH/H timeslot still has room for a second lchan. This is particularly<br>bad for dynamic timeslots, reducing PDCH as well as TCH/F resources.<br><br>Change-Id: If222835af92d832b848824e5466bdcaf9af8a614<br>---<br>M tests/handover/handover_test.c<br>M tests/testsuite.at<br>2 files changed, 19 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/21202/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index 46f7cb8..d2d3229 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -1694,6 +1694,18 @@</span><br><span>    NULL</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static char *test_case_31[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+       "2",</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      "Congestion check: re-use half used TCH/H to avoid switching more dyn TS to TCH/H\n"</span><br><span style="color: hsl(120, 100%, 40%);">+        ,</span><br><span style="color: hsl(120, 100%, 40%);">+     "create-bts", "1", "c+s4", "TCH/F", "TCH/F", "TCH/F", "dyn", "dyn", "dyn", "PDCH",</span><br><span style="color: hsl(120, 100%, 40%);">+        "set-ts-use", "0", "0",  "*", "-", "-", "-", "PDCH", "TCH/H-", "PDCH", "PDCH",</span><br><span style="color: hsl(120, 100%, 40%);">+  "create-ms", "0", "TCH/H", "AMR",</span><br><span style="color: hsl(120, 100%, 40%);">+     /* bad: should re-use existing dyn TS instead of switching another one */</span><br><span style="color: hsl(120, 100%, 40%);">+     "expect-ts-use", "0", "0",  "*", "-", "-", "-", "TCH/H-", "TCH/H-", "PDCH", "PDCH",</span><br><span style="color: hsl(120, 100%, 40%);">+     NULL</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span> </span><br><span> static char **test_cases[] =  {</span><br><span>      test_case_0,</span><br><span>@@ -1727,6 +1739,7 @@</span><br><span>         test_case_28,</span><br><span>        test_case_29,</span><br><span>        test_case_30,</span><br><span style="color: hsl(120, 100%, 40%);">+ test_case_31,</span><br><span> };</span><br><span> </span><br><span> static const struct log_info_cat log_categories[] = {</span><br><span>diff --git a/tests/testsuite.at b/tests/testsuite.at</span><br><span>index 787f33d..bd6f56f 100644</span><br><span>--- a/tests/testsuite.at</span><br><span>+++ b/tests/testsuite.at</span><br><span>@@ -236,3 +236,9 @@</span><br><span> cat $abs_srcdir/handover/handover_test.ok > expout</span><br><span> AT_CHECK([$abs_top_builddir/tests/handover/handover_test 30], [], [expout], [ignore])</span><br><span> AT_CLEANUP</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+AT_SETUP([handover test 31])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_KEYWORDS([handover])</span><br><span style="color: hsl(120, 100%, 40%);">+cat $abs_srcdir/handover/handover_test.ok > expout</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CHECK([$abs_top_builddir/tests/handover/handover_test 31], [], [expout], [ignore])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CLEANUP</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21202">change 21202</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21202"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If222835af92d832b848824e5466bdcaf9af8a614 </div>
<div style="display:none"> Gerrit-Change-Number: 21202 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>