<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21193">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_test prep: rename 'create-bts' to 'create-n-bts'<br><br>I will add a command to create a single BTS with arbitrary timeslot<br>configurations.<br><br>To limit amount of editing of the current tests, keep the current 'create-bts'<br>command, which creates N identically configured BTS, but rename it to<br>'create-n-bts'.<br><br>Thus allow the upcoming single-BTS command to take the name 'create-bts'.<br><br>Change-Id: I4853771cf23b509b7f278d04c57883332ede786d<br>---<br>M tests/handover/handover_test.c<br>1 file changed, 31 insertions(+), 31 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/21193/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index fefeb0c..3ceaf31 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -508,7 +508,7 @@</span><br><span> "There are many neighbor cells, but only the current cell is the best\n"</span><br><span> "cell, so no handover is performed\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "7",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "7",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "30","0",</span><br><span> "6","0","20","1","21","2","18","3","20","4","23","5","19",</span><br><span>@@ -522,7 +522,7 @@</span><br><span> "Handover to best better cell\n\n"</span><br><span> "The best neighbor cell is selected\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "7",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "7",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "10","0",</span><br><span> "6","0","20","1","21","2","18","3","20","4","23","5","19",</span><br><span>@@ -545,7 +545,7 @@</span><br><span> "in the current cell, but disabling in the neighbor cell, handover\n"</span><br><span> "will not be performed, until it is enabled in the neighbor cell too.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "afs-rxlev-improve", "0", "5",</span><br><span> "create-ms", "0", "TCH/H", "AMR",</span><br><span> "as-enable", "0", "0",</span><br><span>@@ -579,7 +579,7 @@</span><br><span> "Even though the cell is still better, handover will not be performed\n"</span><br><span> "due to penalty timer after handover failure\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "20","0", "1","0","30",</span><br><span> "expect-chan", "1", "1",</span><br><span>@@ -599,7 +599,7 @@</span><br><span> "at TCH/H slots. As the congestion is removed, the handover takes\n"</span><br><span> "place.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "1", "TCH/H", "4",</span><br><span> "create-ms", "0", "TCH/H", "HR",</span><br><span> "meas-rep", "0", "20","0", "1","0","30",</span><br><span>@@ -621,7 +621,7 @@</span><br><span> "at TCH/F slots. As the congestion is removed, the handover takes\n"</span><br><span> "place.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span> "create-ms", "0", "TCH/F", "FR",</span><br><span> "meas-rep", "0", "20","0", "1","0","30",</span><br><span>@@ -643,7 +643,7 @@</span><br><span> "at TCH/F slots. As the congestion is removed, the handover takes\n"</span><br><span> "place.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span> "create-ms", "0", "TCH/F", "EFR",</span><br><span> "meas-rep", "0", "20","0", "1","0","30",</span><br><span>@@ -664,7 +664,7 @@</span><br><span> "The MS is using AMR V3 codec, the better cell is congested at TCH/F\n"</span><br><span> "slots. The handover is performed to non-congested TCH/H slots.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "20","0", "1","0","30",</span><br><span>@@ -681,7 +681,7 @@</span><br><span> "No handover to a cell with no slots available\n\n"</span><br><span> "If no slot is available, no handover is performed\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "create-ms", "1", "TCH/F", "AMR",</span><br><span> "create-ms", "1", "TCH/F", "AMR",</span><br><span>@@ -703,7 +703,7 @@</span><br><span> "There are tree mobiles that want to handover, but only two can do\n"</span><br><span> "it at a time, because the maximum number is limited to two.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-max-ho", "1", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span>@@ -724,7 +724,7 @@</span><br><span> "If neighbor cell is better, handover is only performed if the\n"</span><br><span> "amount of improvement is greater or equal hyteresis\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "27","0", "1","0","30",</span><br><span> "expect-no-chan",</span><br><span>@@ -748,7 +748,7 @@</span><br><span> "is below minimum RX level, even if the better neighbor cell (minimum\n"</span><br><span> "RX level reached) does not meet the hysteresis.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "10","0", "1","0","11",</span><br><span> "expect-no-chan",</span><br><span>@@ -769,7 +769,7 @@</span><br><span> "The better neighbor cell is congested, so no handover is performed.\n"</span><br><span> "After the congestion is over, handover will be performed.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span> "set-min-free", "1", "TCH/H", "4",</span><br><span>@@ -794,7 +794,7 @@</span><br><span> "more. After congestion raises in the current cell, the handover is\n"</span><br><span> "performed to balance congestion\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "set-min-free", "0", "TCH/F", "4",</span><br><span> "set-min-free", "0", "TCH/H", "4",</span><br><span>@@ -819,7 +819,7 @@</span><br><span> "If the RX level of the current cell drops below minimum acceptable\n"</span><br><span> "level, the handover is performed.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span> "set-min-free", "1", "TCH/H", "4",</span><br><span>@@ -846,7 +846,7 @@</span><br><span> * See Performance Enhancements in a Frequency Hopping GSM Network (Nielsen Wigard 2002), Chapter</span><br><span> * 2.1.1, "Interference" in the list of triggers on p.157. */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "40","6", "1","0","30",</span><br><span> "expect-no-chan",</span><br><span>@@ -884,7 +884,7 @@</span><br><span> "performed back to that cell, because the penalty timer (due to\n"</span><br><span> "maximum allowed timing advance) is running.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "set-max-ta", "0", "5", /* of cell */</span><br><span> "set-ta", "0", "5", /* of ms */</span><br><span>@@ -908,7 +908,7 @@</span><br><span> "Three cells have different number of used slots, but there is no\n"</span><br><span> "congestion in any of these cells. No handover is performed.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "3",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "3",</span><br><span> "set-min-free", "0", "TCH/F", "2",</span><br><span> "set-min-free", "0", "TCH/H", "2",</span><br><span> "set-min-free", "1", "TCH/F", "2",</span><br><span>@@ -946,7 +946,7 @@</span><br><span> "congestion at TCH/F in the first cell. Handover is performed with\n"</span><br><span> "the best candidate.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "3",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "3",</span><br><span> "set-min-free", "0", "TCH/F", "2",</span><br><span> "set-min-free", "0", "TCH/H", "2",</span><br><span> "set-min-free", "1", "TCH/F", "2",</span><br><span>@@ -989,7 +989,7 @@</span><br><span> "Two cells are congested, but the second cell is less congested.\n"</span><br><span> "Handover is performed to solve the congestion.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "0", "TCH/F", "4",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span> "create-ms", "0", "TCH/F", "FR",</span><br><span>@@ -1018,7 +1018,7 @@</span><br><span> "Congestion check: Solving congestion by handover TCH/F -> TCH/H\n\n"</span><br><span> "Two BTS, one MS in the first congested BTS must handover to\n"</span><br><span> "non-congested TCH/H of second BTS, in order to solve congestion\n",</span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "0", "TCH/F", "4",</span><br><span> "set-min-free", "0", "TCH/H", "4",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span>@@ -1039,7 +1039,7 @@</span><br><span> "Congestion check: Balancing congestion by handover TCH/F -> TCH/H\n\n"</span><br><span> "Two BTS, one MS in the first congested BTS must handover to\n"</span><br><span> "less-congested TCH/H of second BTS, in order to balance congestion\n",</span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "0", "TCH/F", "4",</span><br><span> "set-min-free", "0", "TCH/H", "4",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span>@@ -1065,7 +1065,7 @@</span><br><span> "assignment is performed to less-congested TCH/F, the candidate with\n"</span><br><span> "the worst RX level is chosen.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "1",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "1",</span><br><span> "set-min-free", "0", "TCH/F", "4",</span><br><span> "set-min-free", "0", "TCH/H", "4",</span><br><span> "create-ms", "0", "TCH/H", "AMR",</span><br><span>@@ -1088,7 +1088,7 @@</span><br><span> </span><br><span> "Story: 'A neighbor is your friend'\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "3",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "3",</span><br><span> </span><br><span> "print",</span><br><span> "Andreas is driving along the coast, on a sunny june afternoon.\n"</span><br><span>@@ -1174,7 +1174,7 @@</span><br><span> "received.\n",</span><br><span> </span><br><span> /* two cells, first in congested, but no handover */</span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "set-min-free", "0", "TCH/F", "4",</span><br><span> "set-min-free", "0", "TCH/H", "4",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span>@@ -1216,7 +1216,7 @@</span><br><span> "There are many neighbor cells, but only the current cell is the best\n"</span><br><span> "cell, so no handover is performed\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "7",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "7",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "30","0",</span><br><span> "6","0","20","1","21","2","18","3","20","4","23","5","19",</span><br><span>@@ -1230,7 +1230,7 @@</span><br><span> "Handover to best better cell\n\n"</span><br><span> "The best neighbor cell is selected\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "7",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "7",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "meas-rep", "0", "10","0",</span><br><span> "6","0","20","1","21","2","18","3","20","4","23","5","19",</span><br><span>@@ -1250,7 +1250,7 @@</span><br><span> "the worst RX level is chosen. (So far like test 22.)\n"</span><br><span> "After that, trigger more congestion checks to ensure stability.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "1",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "1",</span><br><span> "set-min-free", "0", "TCH/F", "2",</span><br><span> "set-min-free", "0", "TCH/H", "4",</span><br><span> "create-ms", "0", "TCH/H", "AMR",</span><br><span>@@ -1286,7 +1286,7 @@</span><br><span> "level, the handover is performed. It is also required that 10\n"</span><br><span> "resports are received, before RX quality is checked.\n",</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "2",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span> "set-min-free", "1", "TCH/F", "4",</span><br><span> "set-min-free", "1", "TCH/H", "4",</span><br><span>@@ -1322,7 +1322,7 @@</span><br><span> "Congestion check: Balancing congestion by handover TCH/F -> TCH/H\n\n"</span><br><span> "One BTS, and TCH/F are considered congested, TCH/H are not.\n"</span><br><span> ,</span><br><span style="color: hsl(0, 100%, 40%);">- "create-bts", "1",</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-n-bts", "1",</span><br><span> "set-min-free", "0", "TCH/F", "3",</span><br><span> "set-min-free", "0", "TCH/H", "0",</span><br><span> "create-ms", "0", "TCH/F", "AMR",</span><br><span>@@ -1523,7 +1523,7 @@</span><br><span> hodec2_init(bsc_gsmnet);</span><br><span> </span><br><span> while (*test_case) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (!strcmp(*test_case, "create-bts")) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!strcmp(*test_case, "create-n-bts")) {</span><br><span> int n = atoi(test_case[1]);</span><br><span> fprintf(stderr, "- Creating %d BTS (one TRX each, "</span><br><span> "TS(1-4) are TCH/F, TS(5-6) are TCH/H)\n", n);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21193">change 21193</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21193"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4853771cf23b509b7f278d04c57883332ede786d </div>
<div style="display:none"> Gerrit-Change-Number: 21193 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>