<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21135">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bitvec: Fix left shifting out of range on signed variable<br><br>Fixes following ASan runtime errors spotted by TypeTest osmo-pcu unit test:<br>libosmocore/src/bitvec.c:275:13: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'<br><br>Change-Id: I70502044d05c0505a4b65c1e12e89ff657afe804<br>---<br>M src/bitvec.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/21135/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bitvec.c b/src/bitvec.c</span><br><span>index d7f32fb..2b4e8c9 100644</span><br><span>--- a/src/bitvec.c</span><br><span>+++ b/src/bitvec.c</span><br><span>@@ -272,7 +272,7 @@</span><br><span>            if (bit < 0)</span><br><span>                      return bit;</span><br><span>          if (bit)</span><br><span style="color: hsl(0, 100%, 40%);">-                        ui |= (1 << (num_bits - i - 1));</span><br><span style="color: hsl(120, 100%, 40%);">+                        ui |= ((unsigned)1 << (num_bits - i - 1));</span><br><span>             bv->cur_bit++;</span><br><span>    }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21135">change 21135</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21135"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I70502044d05c0505a4b65c1e12e89ff657afe804 </div>
<div style="display:none"> Gerrit-Change-Number: 21135 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>