<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21129">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">move f_gen_{imsi,imei,msisdn} from L3_Templates to Osmocom_Types<br><br>Those functions don't depend on any L3 specific data structurs, and<br>it is not a good idea to burden every user with having to impot all<br>of a 2G/3G Layer3 just to generate some hexstring identifiers.<br><br>Change-Id: I7880633a46afc607f16f8aa6ea1a277f7958c95b<br>---<br>M library/L3_Templates.ttcn<br>M library/Osmocom_Types.ttcn<br>2 files changed, 22 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/21129/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn</span><br><span>index 2ef8773..2eb0bb2 100644</span><br><span>--- a/library/L3_Templates.ttcn</span><br><span>+++ b/library/L3_Templates.ttcn</span><br><span>@@ -2968,26 +2968,6 @@</span><br><span> </span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_concat_pad(integer tot_len, hexstring prefix, integer suffix) return hexstring {</span><br><span style="color: hsl(0, 100%, 40%);">- var integer suffix_len := tot_len - lengthof(prefix);</span><br><span style="color: hsl(0, 100%, 40%);">- var charstring suffix_ch := int2str(suffix);</span><br><span style="color: hsl(0, 100%, 40%);">- var integer pad_len := suffix_len - lengthof(suffix_ch);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return prefix & int2hex(0, pad_len) & str2hex(suffix_ch);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-function f_gen_imei(integer suffix) return hexstring {</span><br><span style="color: hsl(0, 100%, 40%);">- return f_concat_pad(14, '49999'H, suffix);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-function f_gen_imsi(integer suffix) return hexstring {</span><br><span style="color: hsl(0, 100%, 40%);">- return f_concat_pad(15, '26242'H, suffix);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-function f_gen_msisdn(integer suffix) return hexstring {</span><br><span style="color: hsl(0, 100%, 40%);">- return f_concat_pad(12, '49123'H, suffix);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> external function enc_MobileIdentityLV(in MobileIdentityLV si) return octetstring</span><br><span> with { extension "prototype(convert) encode(RAW)" };</span><br><span> </span><br><span>diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn</span><br><span>index ee3b04a..4012f6d 100644</span><br><span>--- a/library/Osmocom_Types.ttcn</span><br><span>+++ b/library/Osmocom_Types.ttcn</span><br><span>@@ -252,4 +252,26 @@</span><br><span> }</span><br><span> </span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_concat_pad(integer tot_len, hexstring prefix, integer suffix) return hexstring {</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer suffix_len := tot_len - lengthof(prefix);</span><br><span style="color: hsl(120, 100%, 40%);">+ var charstring suffix_ch := int2str(suffix);</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer pad_len := suffix_len - lengthof(suffix_ch);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return prefix & int2hex(0, pad_len) & str2hex(suffix_ch);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_gen_imei(integer suffix) return hexstring {</span><br><span style="color: hsl(120, 100%, 40%);">+ return f_concat_pad(14, '49999'H, suffix);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_gen_imsi(integer suffix) return hexstring {</span><br><span style="color: hsl(120, 100%, 40%);">+ return f_concat_pad(15, '26242'H, suffix);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_gen_msisdn(integer suffix) return hexstring {</span><br><span style="color: hsl(120, 100%, 40%);">+ return f_concat_pad(12, '49123'H, suffix);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> } with { encode "RAW"; variant "FIELDORDER(msb)" }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21129">change 21129</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21129"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7880633a46afc607f16f8aa6ea1a277f7958c95b </div>
<div style="display:none"> Gerrit-Change-Number: 21129 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>