<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21088">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: also include SRR bit in RSL l1 info field.<br><br>The SRR bit, which got specified in 3gpp release 6 to support repeated<br>ACCH capability is not yet included in the L1 Information IE on RSL<br>level. Also lets update the spec reference to more modern 3gpp spec ref<br>numbers.<br><br>Change-Id: I987c61608b737521ba36756dabf2f6215b34c2d6<br>Related: OS#4796 SYS#5114<br>---<br>M src/common/l1sap.c<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/21088/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 316ea1b..7e8292a 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1410,12 +1410,12 @@</span><br><span>                  LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with size %u<2 !?!\n", len);</span><br><span>                      return -EINVAL;</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-               /* Some brilliant engineer decided that the ordering of</span><br><span style="color: hsl(0, 100%, 40%);">-          * fields on the Um interface is different from the</span><br><span style="color: hsl(0, 100%, 40%);">-              * order of fields in RSL. See TS 04.04 (Chapter 7.2)</span><br><span style="color: hsl(0, 100%, 40%);">-            * vs. TS 08.58 (Chapter 9.3.10). */</span><br><span style="color: hsl(120, 100%, 40%);">+          /* Note: The ordering of the fields on the Um interface fields</span><br><span style="color: hsl(120, 100%, 40%);">+                 * is reversed on RSL level, see also: 3GPP TS 44.004 (section 7.2)</span><br><span style="color: hsl(120, 100%, 40%);">+            * and 3GPP TS 48.058 (section 9.3.10). */</span><br><span>           lchan->meas.l1_info[0] = data[0] << 3;</span><br><span style="color: hsl(0, 100%, 40%);">-         lchan->meas.l1_info[0] |= ((data[0] >> 5) & 1) << 2;</span><br><span style="color: hsl(120, 100%, 40%);">+               lchan->meas.l1_info[0] |= ((data[0] >> 5) & 1) << 2; /* FPC/EPC */</span><br><span style="color: hsl(120, 100%, 40%);">+         lchan->meas.l1_info[0] |= ((data[0] >> 6) & 1) << 1; /* SRR */</span><br><span>            lchan->meas.l1_info[1] = data[1];</span><br><span>                 lchan->meas.flags |= LC_UL_M_F_L1_VALID;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21088">change 21088</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21088"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I987c61608b737521ba36756dabf2f6215b34c2d6 </div>
<div style="display:none"> Gerrit-Change-Number: 21088 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>