<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21051">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Introduce test TC_cs_max_dl and TC_dl_cs1_to_cs4<br><br>Change-Id: If847d091f3f4e6a7c77fbadc7280423637c50b35<br>---<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 116 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 7093f31..1cbca4c 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -949,19 +949,12 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* High level (task specific) helper for receiving and matching GPRS/EGPRS data blocks */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_rx_rlcmac_dl_block_exp_data(out RlcmacDlBlock dl_block, out uint32_t dl_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+/* High level (task specific) helper for matching GPRS/EGPRS data blocks */</span><br><span style="color: hsl(120, 100%, 40%);">+function f_rlcmac_dl_block_exp_data(in RlcmacDlBlock dl_block,</span><br><span> template (present) octetstring data := ?,</span><br><span> template (present) uint7_t exp_bsn := ?,</span><br><span style="color: hsl(0, 100%, 40%);">- template (present) CodingScheme exp_cs := ?,</span><br><span style="color: hsl(0, 100%, 40%);">- template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)</span><br><span style="color: hsl(120, 100%, 40%);">+ template (present) CodingScheme exp_cs := ?)</span><br><span> runs on MS_BTS_IFACE_CT {</span><br><span style="color: hsl(0, 100%, 40%);">- /* FIXME: ideally we should use an alt statement with timeout here, rather than</span><br><span style="color: hsl(0, 100%, 40%);">- * having +100500 layers of abstraction. This would facilitate developing the</span><br><span style="color: hsl(0, 100%, 40%);">- * multi-TBF/-TRX/-BTS tests, where you cannot expect that the first received</span><br><span style="color: hsl(0, 100%, 40%);">- * block is exactly what you need. */</span><br><span style="color: hsl(0, 100%, 40%);">- f_rx_rlcmac_dl_block(dl_block, dl_fn, nr := nr);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Make sure it's either GPRS or EGPRS data block */</span><br><span> if (not match(dl_block, tr_RLCMAC_DATA)) {</span><br><span> setverdict(fail, "Failed to match DL DATA: ", dl_block, " vs ", tr_RLCMAC_DATA);</span><br><span>@@ -979,6 +972,22 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* High level (task specific) helper for receiving and matching GPRS/EGPRS data blocks */</span><br><span style="color: hsl(120, 100%, 40%);">+function f_rx_rlcmac_dl_block_exp_data(out RlcmacDlBlock dl_block, out uint32_t dl_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (present) octetstring data := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (present) uint7_t exp_bsn := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (present) CodingScheme exp_cs := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on MS_BTS_IFACE_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: ideally we should use an alt statement with timeout here, rather than</span><br><span style="color: hsl(120, 100%, 40%);">+ * having +100500 layers of abstraction. This would facilitate developing the</span><br><span style="color: hsl(120, 100%, 40%);">+ * multi-TBF/-TRX/-BTS tests, where you cannot expect that the first received</span><br><span style="color: hsl(120, 100%, 40%);">+ * block is exactly what you need. */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block(dl_block, dl_fn, nr := nr);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rlcmac_dl_block_exp_data(dl_block, data, exp_bsn, exp_cs);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> function f_dl_block_ack_fn(in RlcmacDlBlock dl_block, uint32_t dl_fn)</span><br><span> runs on MS_BTS_IFACE_CT return uint32_t {</span><br><span> var boolean rrbp_valid;</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index aa4d28d..4df040e 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -867,6 +867,101 @@</span><br><span> f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify scheduling of multiple Downlink data blocks, enough to reach CS4 */</span><br><span style="color: hsl(120, 100%, 40%);">+function f_dl_data_exp_cs(template CodingScheme exp_cs := ?) runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring data := f_rnd_octstring(1000);</span><br><span style="color: hsl(120, 100%, 40%);">+ var RlcmacDlBlock prev_dl_block, dl_block;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t ack_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GprsMS ms;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer tx_data_remain := 5;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer bsn := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait timer X2002 and DL block is available after CCCH IMM ASS */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(X2002);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < 250; i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ bsn := i mod 128;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block(dl_block, fn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (match(dl_block, tr_RLCMAC_DUMMY_CTRL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* No more data to receive, done */</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rlcmac_dl_block_exp_data(dl_block, ?, bsn, cs_gprs_any);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Keep Ack/Nack description updated */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TDMA frame number on which we are supposed to send the ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dl_block.data.mac_hdr.mac_hdr.rrbp_valid) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ack_fn := f_dl_block_ack_fn(dl_block, fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf.tfi, ms.dl_tbf.acknack_desc), ack_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tx_data_remain != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Submit more data from time to time to keep the TBF ongoing */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data));</span><br><span style="color: hsl(120, 100%, 40%);">+ tx_data_remain := tx_data_remain - 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ prev_dl_block := dl_block;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bsn := (bsn + 127) mod 128; /* previous bsn: bsn -1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rlcmac_dl_block_exp_data(prev_dl_block, ?, bsn, exp_cs);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify DL CS above "cs max" set by VTY is never used */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_cs_max_dl() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename(), ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Set maximum allowed DL CS to 3 */</span><br><span style="color: hsl(120, 100%, 40%);">+ g_cs_initial_dl := 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_cs_max_dl := 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pcuvty_set_allowed_cs_mcs();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pcuvty_set_link_quality_ranges();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_dl_data_exp_cs(f_rlcmac_block_int2cs_mcs(g_cs_max_dl, false));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Check DL CS4 is used in good link conditions if allowed by config */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_dl_cs1_to_cs4() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename(), ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Set initial DL CS to 1 & maximum allowed DL CS to 4 */</span><br><span style="color: hsl(120, 100%, 40%);">+ g_cs_initial_dl := 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_cs_max_dl := 4;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pcuvty_set_allowed_cs_mcs();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pcuvty_set_link_quality_ranges();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_dl_data_exp_cs(f_rlcmac_block_int2cs_mcs(g_cs_max_dl, false));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Verify PCU drops TBF after some time of inactivity. */</span><br><span> testcase TC_t3169() runs on RAW_PCU_Test_CT {</span><br><span> var PCUIF_info_ind info_ind;</span><br><span>@@ -2915,6 +3010,8 @@</span><br><span> execute( TC_cs_initial_ul() );</span><br><span> execute( TC_cs_max_ul() );</span><br><span> execute( TC_cs_initial_dl() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_cs_max_dl() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_dl_cs1_to_cs4() );</span><br><span> execute( TC_t3169() );</span><br><span> execute( TC_t3193() );</span><br><span> execute( TC_countdown_procedure() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21051">change 21051</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21051"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If847d091f3f4e6a7c77fbadc7280423637c50b35 </div>
<div style="display:none"> Gerrit-Change-Number: 21051 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>