<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21082">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_08_58: add proprietary IE to signal Repeated ACCH Capability<br><br>3GPP TS 24.008, section 10.5.1.7 specifies a Repeated ACCH Capability<br>bit in the Classmark 3 IE. Unfortunately, there is no way specified how<br>the Repeated ACCH feature should be controlled on RSL level. Since it is<br>not unusual that BTS/BSC vendors occassionally add proprietary IEs to<br>different RSL messages we may pick this as a solution as well and add a<br>propritary RSL_IE_OSMO_REP_ACCH_CAP IE, so that we can enable repeated<br>FACCH/SACCH on the BTS side when we send RSL CHAN ACT or RSL CHAN MODE MODIFY<br>messages.<br><br>Change-Id: I61ea6bf54ea90bd69b73ea0f0f3dc19a4214207b<br>Related: OS#4796 SYS#5114<br>---<br>M include/osmocom/gsm/protocol/gsm_08_58.h<br>M src/gsm/rsl.c<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h</span><br><span>index cd13a7d..95da23a 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_08_58.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_08_58.h</span><br><span>@@ -337,6 +337,9 @@</span><br><span>    RSL_IE_SIEMENS_HIGHEST_RATE     = 0x4e,</span><br><span>      RSL_IE_SIEMENS_SUGGESTED_RATE   = 0x4f,</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   /* Osmocom specific */</span><br><span style="color: hsl(120, 100%, 40%);">+        RSL_IE_OSMO_REP_ACCH_CAP= 0x60,</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    /* ip.access */</span><br><span>      RSL_IE_IPAC_SRTP_CONFIG = 0xe0,</span><br><span>      RSL_IE_IPAC_PROXY_UDP   = 0xe1,</span><br><span>diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c</span><br><span>index c3420b6..2ab49c2 100644</span><br><span>--- a/src/gsm/rsl.c</span><br><span>+++ b/src/gsm/rsl.c</span><br><span>@@ -126,6 +126,7 @@</span><br><span>               [RSL_IE_TFO_STATUS]             = { TLV_TYPE_TV },</span><br><span>           [RSL_IE_LLP_APDU]               = { TLV_TYPE_TLV },</span><br><span>          [RSL_IE_SIEMENS_MRPCI]          = { TLV_TYPE_TV },</span><br><span style="color: hsl(120, 100%, 40%);">+            [RSL_IE_OSMO_REP_ACCH_CAP]      = { TLV_TYPE_TLV },</span><br><span>          [RSL_IE_IPAC_PROXY_UDP]         = { TLV_TYPE_FIXED, 2 },</span><br><span>             [RSL_IE_IPAC_BSCMPL_TOUT]       = { TLV_TYPE_TV },</span><br><span>           [RSL_IE_IPAC_REMOTE_IP]         = { TLV_TYPE_FIXED, 4 },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21082">change 21082</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21082"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I61ea6bf54ea90bd69b73ea0f0f3dc19a4214207b </div>
<div style="display:none"> Gerrit-Change-Number: 21082 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>