<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/21046">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ms: Avoid enabling EGPRS if no MCS are supported<br><br>This patch avoids enabling EGPRS on MS objects if BTS/VTY assigned no<br>MCS supported/available for use.<br>As a result, if NO MCS is enabled/supported EGPRS won't be used despite<br>the MS announcing through EGPRS MS class that it supports EGPRS.<br><br>Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3<br>---<br>M src/gprs_ms.cpp<br>M src/tbf.cpp<br>2 files changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp</span><br><span>index b295686..8eb23d9 100644</span><br><span>--- a/src/gprs_ms.cpp</span><br><span>+++ b/src/gprs_ms.cpp</span><br><span>@@ -541,6 +541,13 @@</span><br><span> </span><br><span>         m_egprs_ms_class = ms_class_;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     if (!m_bts->max_mcs_ul() || !m_bts->max_mcs_dl()) {</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGPMS(this, DRLCMAC, LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+                    "Avoid enabling EGPRS because use of MCS is disabled: ul=%u dl=%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        m_bts->max_mcs_ul(), m_bts->max_mcs_dl());</span><br><span style="color: hsl(120, 100%, 40%);">+              return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (mcs_is_edge_gmsk(mcs_get_egprs_by_num(m_bts->max_mcs_ul())) &&</span><br><span>                mcs_is_edge_gmsk(mcs_get_egprs_by_num(m_bts->max_mcs_dl())) &&</span><br><span>            mode() != EGPRS)</span><br><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 4f685e8..2371aed 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -745,7 +745,7 @@</span><br><span>      struct gprs_rlcmac_bts *bts_data = bts->bts_data();</span><br><span>       int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (m_ms->egprs_ms_class() > 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (m_ms->mode() != GPRS)</span><br><span>                 enable_egprs();</span><br><span> </span><br><span>  m_created_ts = time(NULL);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/21046">change 21046</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/21046"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3 </div>
<div style="display:none"> Gerrit-Change-Number: 21046 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>