<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21050">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: f_acknackdesc_ack_block: Fix BSN wrap-around<br><br>Change-Id: Ibe90e58e04ae5e24c36a0b3dda6742080107bd51<br>---<br>M pcu/GPRS_Components.ttcn<br>1 file changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 234d910..7093f31 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -625,12 +625,18 @@</span><br><span>            bsn := dl_block.data_egprs.mac_hdr.bsn1;</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   inc := bsn - desc.starting_seq_nr + 1;</span><br><span>       /* Filling hole? */</span><br><span>  if (bsn < desc.starting_seq_nr) {</span><br><span>                 desc.receive_block_bitmap[lengthof(desc.receive_block_bitmap) - (desc.starting_seq_nr - bsn)] := int2bit(1, 1);</span><br><span>              return;</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Filling hole, wraparound: */</span><br><span style="color: hsl(120, 100%, 40%);">+       if (bsn - desc.starting_seq_nr > lengthof(desc.receive_block_bitmap)) {</span><br><span style="color: hsl(120, 100%, 40%);">+            desc.receive_block_bitmap[lengthof(desc.receive_block_bitmap) - (desc.starting_seq_nr + (218 - bsn))] := int2bit(1, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+               return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   inc := bsn - desc.starting_seq_nr + 1;</span><br><span> </span><br><span>   /* SSN is increased, and so RBB values need to be moved */</span><br><span>   for (i := 0; i < lengthof(desc.receive_block_bitmap) - inc; i := i+1) {</span><br><span>@@ -640,7 +646,7 @@</span><br><span>             desc.receive_block_bitmap[i] := int2bit(0, 1);</span><br><span>       }</span><br><span>    /* Now we can set current bit and update SSN */</span><br><span style="color: hsl(0, 100%, 40%);">- desc.starting_seq_nr := bsn + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+      desc.starting_seq_nr := (bsn + 1) mod 128;</span><br><span>   desc.receive_block_bitmap[lengthof(desc.receive_block_bitmap) - 1] := int2bit(1, 1);</span><br><span> </span><br><span>     /* Finally update the final_ack bit as requested: */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21050">change 21050</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21050"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibe90e58e04ae5e24c36a0b3dda6742080107bd51 </div>
<div style="display:none"> Gerrit-Change-Number: 21050 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>