<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_2phase<br><br>Change-Id: Ie0035bab79c286a968394d7b724d975f43d187ce<br>---<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 101 insertions(+), 24 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index f2b0efb..f9697a1 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -41,6 +41,12 @@</span><br><span> uint8_t blk_nr</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Useful to store poll FN + BTS+TRX+TS requested by network */</span><br><span style="color: hsl(120, 100%, 40%);">+type record PollFnCtx {</span><br><span style="color: hsl(120, 100%, 40%);">+ TsTrxBtsNum tstrxbts,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t fn</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> template (value) TsTrxBtsNum ts_TsTrxBtsNum(uint3_t ts_nr := 7,</span><br><span> uint3_t trx_nr := 0,</span><br><span> uint8_t bts_nr := 0,</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 44213a7..bb17190 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -267,6 +267,47 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_ms_establish_ul_tbf_2phase_access(inout GprsMS ms,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (omit) RlcmacUlCtrlMsg pkt_res_req := omit)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on RAW_PCU_Test_CT return PollFnCtx {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PollFnCtx pollctx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Single block (two phase) packet access */</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint16_t ra := bit2int(chan_req_sb);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (g_force_two_phase_access) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* If 2phase access is enforced by the network, then let's</span><br><span style="color: hsl(120, 100%, 40%);">+ * request a One phase packet access, we'll receive a single block</span><br><span style="color: hsl(120, 100%, 40%);">+ * anyway</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ ra := bit2int(chan_req_def);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish an Uplink TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_use_ra(ms, ra, ra_is_11bit := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure we've got an Uplink TBF assignment */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(ms.ul_tbf.ass.ccch, tr_PacketUlSglAssign)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Wrong Packet Uplink Assignment received: ", ms.ul_tbf.ass.ccch, " vs exp: ", tr_PacketUlSglAssign);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send PACKET RESOURCE REQUEST</span><br><span style="color: hsl(120, 100%, 40%);">+ * (see 3GPP TS 04.60 "7.1.3.1 Initiation of the Packet resource request procedure")</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (istemplatekind(pkt_res_req, "omit")) {</span><br><span style="color: hsl(120, 100%, 40%);">+ pkt_res_req := ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, omit);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(pkt_res_req), 0, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Store 1st UlTBF context before receiving next one, will will</span><br><span style="color: hsl(120, 100%, 40%);">+ * overwrite the TS allocation on MS with info from new UL TBF:</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ pollctx.tstrxbts := f_ms_tx_TsTrxBtsNum(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_rx_pkt_ass_pacch(ms, pollctx.fn, tr_RLCMAC_UL_PACKET_ASS, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span style="color: hsl(120, 100%, 40%);">+ return pollctx;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> testcase TC_pcuif_suspend() runs on RAW_PCU_Test_CT {</span><br><span> var octetstring ra_id := enc_RoutingAreaIdentification(mp_gb_cfg.bvc[0].cell_id.ra_id);</span><br><span> var GprsTlli tlli := 'FFFFFFFF'O;</span><br><span>@@ -1156,20 +1197,12 @@</span><br><span> runs on RAW_PCU_Test_CT {</span><br><span> var RlcmacDlBlock dl_block;</span><br><span> var octetstring data := f_rnd_octstring(10);</span><br><span style="color: hsl(120, 100%, 40%);">+ var PollFnCtx pollctx;</span><br><span> var uint32_t sched_fn;</span><br><span> var uint32_t dl_fn;</span><br><span> var uint32_t unused_fn;</span><br><span> var GprsMS ms;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Single block (two phase) packet access */</span><br><span style="color: hsl(0, 100%, 40%);">- var uint16_t ra := bit2int(chan_req_sb);</span><br><span style="color: hsl(0, 100%, 40%);">- if (g_force_two_phase_access) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* If 2phase access is enforced by the network, then let's</span><br><span style="color: hsl(0, 100%, 40%);">- request a One phase packet access, we'll receive a single block</span><br><span style="color: hsl(0, 100%, 40%);">- anyway */</span><br><span style="color: hsl(0, 100%, 40%);">- ra := bit2int(chan_req_def);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Initialize NS/BSSGP side */</span><br><span> f_init_bssgp();</span><br><span> /* Initialize GPRS MS side */</span><br><span>@@ -1183,21 +1216,9 @@</span><br><span> f_bssgp_establish();</span><br><span> f_bssgp_client_llgmm_assign('FFFFFFFF'O, ms.tlli);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Establish an Uplink TBF */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_use_ra(ms, ra, ra_is_11bit := 0);</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send PACKET RESOURCE REQUEST to upgrade to EGPRS */</span><br><span style="color: hsl(120, 100%, 40%);">+ pollctx := f_ms_establish_ul_tbf_2phase_access(ms, ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, ms_racap));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure we've got an Uplink TBF assignment */</span><br><span style="color: hsl(0, 100%, 40%);">- if (not match(ms.ul_tbf.ass.ccch, tr_PacketUlSglAssign)) {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Wrong Packet Uplink Assignment received: ", ms.ul_tbf.ass.ccch, " vs exp: ", tr_PacketUlSglAssign);</span><br><span style="color: hsl(0, 100%, 40%);">- f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Send PACKET RESOURCE REQUEST to upgrade to EGPRS</span><br><span style="color: hsl(0, 100%, 40%);">- * (see 3GPP TS 04.60 "7.1.3.1 Initiation of the Packet resource request procedure")</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, ms_racap)), 0);</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_rx_pkt_ass_pacch(ms, sched_fn, tr_RLCMAC_UL_PACKET_ASS);</span><br><span> if (not match(ms.ul_tbf.tx_cs_mcs, exp_ul_cs_mcs)) {</span><br><span> setverdict(fail, "Wrong CS_MCS ", ms.ul_tbf.tx_cs_mcs, " received vs exp ", exp_ul_cs_mcs);</span><br><span> f_shutdown(__BFILE__, __LINE__);</span><br><span>@@ -1208,7 +1229,7 @@</span><br><span> f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true); /* TODO: send using cs_mcs */</span><br><span> </span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), pollctx.fn, nr := pollctx.tstrxbts);</span><br><span> </span><br><span> /* UL block should be received in SGSN */</span><br><span> BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.bvc[0].cell_id));</span><br><span>@@ -1720,6 +1741,55 @@</span><br><span> f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_dl_multislot_tbf_ms_class_from_2phase() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PCUIF_info_ind info_ind := valueof(ts_PCUIF_INFO_default);</span><br><span style="color: hsl(120, 100%, 40%);">+ var RlcmacDlBlock dl_block;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring data := f_rnd_octstring(10);</span><br><span style="color: hsl(120, 100%, 40%);">+ var PollFnCtx pollctx;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t sched_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GprsMS ms;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var MultislotCap_GPRS mscap_gprs := {</span><br><span style="color: hsl(120, 100%, 40%);">+ gprsmultislotclass := '10010'B, /* MS class 18, supports 8 DL and 8 UL */</span><br><span style="color: hsl(120, 100%, 40%);">+ gprsextendeddynalloccap := '0'B</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+ var MSRadioAccessCapabilityV ms_racap := { valueof(ts_RaCapRec('0001'B /* E-GSM */, mscap_gprs, omit)) };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+ ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Only 1 TRX with 8 PDCH */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, '11111111'B, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, '00000000'B, (1 .. 7));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename(), info_ind);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send PACKET RESOURCE REQUEST to notify the MultiSlot Class */</span><br><span style="color: hsl(120, 100%, 40%);">+ pollctx := f_ms_establish_ul_tbf_2phase_access(ms, ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, ms_racap));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Pkt Uplink Assignment above sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), pollctx.fn, nr := pollctx.tstrxbts);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data));</span><br><span style="color: hsl(120, 100%, 40%);">+ dl_block := f_ms_rx_pkt_ass_pacch(ms, sched_fn, tr_RLCMAC_DL_PACKET_ASS, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_dltbf_num_slots(ms.dl_tbf) != 8) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Expected 8 PDCH slot allocated but got ", f_dltbf_num_slots(ms.dl_tbf));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Test scenario where MS wants to request a new TBF once the current one is</span><br><span> * ending, by means of sending a Packet Resource Request on ul slot provided by</span><br><span> * last Pkt Ul ACK's RRBP.</span><br><span>@@ -2807,6 +2877,7 @@</span><br><span> execute( TC_pcuif_fh_pkt_ass_dl() );</span><br><span> execute( TC_multitrx_multims_alloc() );</span><br><span> execute( TC_dl_multislot_tbf_ms_class_from_sgsn() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_dl_multislot_tbf_ms_class_from_2phase() );</span><br><span> }</span><br><span> </span><br><span> execute( TC_pcuif_info_ind_subsequent() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967">change 20967</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie0035bab79c286a968394d7b724d975f43d187ce </div>
<div style="display:none"> Gerrit-Change-Number: 20967 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>