<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20929">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: Process received CS1-4 data blocks regardless of egprs_enabled<br><br>EGPRS "enabled" or "not enabled" is a bit of confusing idea, since there<br>are different levels of EGPRS support. For instance we may have been<br>instructed by config to not transmit using MCS5-9 (8PSK), or not use<br>MCS1-9 at all (GMSK+8PSK). However, we cannot control what is sent to us<br>or what we receive on lower layers, so if the BTS PHY/receiver was able<br>to decode+receive, let's try to process it anyway...<br><br>Related: OS#4544<br>Change-Id: Ie70ec8e4a2d688762d7d320d6ad58d5a0cc52ea1<br>---<br>M src/pdch.cpp<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index c56776f..ff13477 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -788,12 +788,6 @@</span><br><span>           bts()->send_gsmtap_meas(PCU_GSMTAP_C_UL_DATA_EGPRS, true,</span><br><span>                                         trx_no(), ts_no, GSMTAP_CHANNEL_PDTCH, fn,</span><br><span>                                   data, data_len, meas);</span><br><span style="color: hsl(0, 100%, 40%);">-          if (!bts()->bts_data()->egprs_enabled) {</span><br><span style="color: hsl(0, 100%, 40%);">-                  LOGP(DRLCMACUL, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                             "Got %s RLC block but EGPRS is not enabled\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                                mcs_name(cs));</span><br><span style="color: hsl(0, 100%, 40%);">-                  return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-               }</span><br><span>    } else {</span><br><span>             bts()->send_gsmtap_meas(PCU_GSMTAP_C_UL_DATA_GPRS, true,</span><br><span>                                  trx_no(), ts_no, GSMTAP_CHANNEL_PDTCH, fn,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20929">change 20929</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20929"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie70ec8e4a2d688762d7d320d6ad58d5a0cc52ea1 </div>
<div style="display:none"> Gerrit-Change-Number: 20929 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>