<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/21045">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix msc_is_valid(): UNKNOWN value is not a valid (M)CS<br><br>Also add a few more asserts to make sure a valid CS/MCS is passed in<br>some placed where we expect (M)CS to be set.<br><br>Change-Id: I0a973e10cd9477f72d8bd47a06048414b33ae96a<br>---<br>M src/coding_scheme.c<br>M src/encoding.cpp<br>M src/rlc.cpp<br>3 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/21045/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/coding_scheme.c b/src/coding_scheme.c</span><br><span>index e39ed2b..27241d1 100644</span><br><span>--- a/src/coding_scheme.c</span><br><span>+++ b/src/coding_scheme.c</span><br><span>@@ -163,7 +163,7 @@</span><br><span> </span><br><span> bool mcs_is_valid(enum CodingScheme cs)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       return UNKNOWN <= cs && cs <= MCS9;</span><br><span style="color: hsl(120, 100%, 40%);">+     return UNKNOWN < cs && cs <= MCS9;</span><br><span> }</span><br><span> </span><br><span> bool mcs_is_compat_kind(enum CodingScheme cs, enum mcs_kind mode)</span><br><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index c6ec2e8..7f5da75 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -1692,6 +1692,7 @@</span><br><span> </span><br><span>      LOGP(DRLCMACDL, LOGL_ERROR, "%s data block encoding not implemented\n",</span><br><span>            mcs_name(cs));</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_ASSERT(mcs_is_valid(cs));</span><br><span> </span><br><span>   return AR_NEED_MORE_BLOCKS;</span><br><span> }</span><br><span>diff --git a/src/rlc.cpp b/src/rlc.cpp</span><br><span>index 4f36025..8f56a8e 100644</span><br><span>--- a/src/rlc.cpp</span><br><span>+++ b/src/rlc.cpp</span><br><span>@@ -350,6 +350,7 @@</span><br><span> void gprs_rlc_data_info_init_dl(struct gprs_rlc_data_info *rlc,</span><br><span>   enum CodingScheme cs, bool with_padding, const unsigned int spb)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(mcs_is_valid(cs));</span><br><span>       return gprs_rlc_data_header_init(rlc, cs, with_padding,</span><br><span>                                       num_data_header_bits_DL(mcs_header_type(cs)), spb);</span><br><span> }</span><br><span>@@ -357,6 +358,7 @@</span><br><span> void gprs_rlc_data_info_init_ul(struct gprs_rlc_data_info *rlc,</span><br><span>   enum CodingScheme cs, bool with_padding)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(mcs_is_valid(cs));</span><br><span>       /*</span><br><span>    * last parameter is sent as 0 since common function used</span><br><span>     * for both DL and UL</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/21045">change 21045</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/21045"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0a973e10cd9477f72d8bd47a06048414b33ae96a </div>
<div style="display:none"> Gerrit-Change-Number: 21045 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>