<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20996">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests/DTX: eliminate redundant f_TC functions<br><br>Change-Id: I4db97d3bea152668c14ce1fb85700364dfdaa575<br>Related: OS#4801<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 3 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 735a36a..a2394a0 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -6705,7 +6705,7 @@</span><br><span> /***********************************************************************</span><br><span> * DTX Related (see GSM 05.08, section 8.3)</span><br><span> ***********************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-private function f_test_l2_fill_frames(boolean dtxd) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_tch_sign_l2_fill_frame(charstring id) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage dl;</span><br><span> var GsmFrameNumber first_fn;</span><br><span> var boolean is_first_frame := true;</span><br><span>@@ -6742,7 +6742,7 @@</span><br><span> first_fn := dl.dl_info.frame_nr;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (dtxd) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (g_pars.chan_mode.dtx_d) {</span><br><span> if (fn > first_fn + frame_dtx_tchf_mod) {</span><br><span> T.stop;</span><br><span> f_rsl_chan_deact();</span><br><span>@@ -6818,14 +6818,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_TC_tch_sign_l2_fill_frame(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(0, 100%, 40%);">- f_test_l2_fill_frames(false);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-private function f_TC_tch_sign_l2_fill_frame_dtxd(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(0, 100%, 40%);">- f_test_l2_fill_frames(true);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> private function f_tch_sign_l2_fill_frame(boolean dtxd) runs on test_CT {</span><br><span> var template RSL_IE_ChannelMode ch_mode;</span><br><span> var ConnHdlr vc_conn;</span><br><span>@@ -6839,10 +6831,8 @@</span><br><span> if (i >= 4) { /* DTX is only allowed on TCH/F */</span><br><span> break;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn := f_start_handler(refers(f_TC_tch_sign_l2_fill_frame_dtxd), pars);</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn := f_start_handler(refers(f_TC_tch_sign_l2_fill_frame), pars);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_tch_sign_l2_fill_frame), pars);</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20996">change 20996</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20996"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4db97d3bea152668c14ce1fb85700364dfdaa575 </div>
<div style="display:none"> Gerrit-Change-Number: 20996 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>