<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20888">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests/DTX: provide more details in failed verdict message<br><br>Change-Id: I15f9303e79750c2864b97697b4378f748a1c7246<br>Related: OS#4801<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 9 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index beea20a..1a659a2 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -6758,9 +6758,9 @@</span><br><span> expected_fill_frames := 2;</span><br><span> </span><br><span> if (nfill_frames < expected_fill_frames) {</span><br><span style="color: hsl(0, 100%, 40%);">- log("received only ", nfill_frames, " out of ",</span><br><span style="color: hsl(0, 100%, 40%);">- expected_fill_frames, " expected fill frames");</span><br><span style="color: hsl(0, 100%, 40%);">- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Not enough fill frames received");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Not enough fill frames received: ",</span><br><span style="color: hsl(120, 100%, 40%);">+ nfill_frames, " out of ", expected_fill_frames);</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> } else {</span><br><span> setverdict(pass);</span><br><span> }</span><br><span>@@ -6775,12 +6775,11 @@</span><br><span> repeat;</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- log("Received DTX TCH fill frame with bad frame number: ", fn,</span><br><span style="color: hsl(0, 100%, 40%);">- " (mod ", frame_dtx_tchf_mod, ": ", fn mod frame_dtx_tchf_mod, ")",</span><br><span style="color: hsl(0, 100%, 40%);">- " (mod ", block_dtx_tchf_mod, ": ", fn mod block_dtx_tchf_mod, ")");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Received DTX TCH fill frame with bad frame number: ", fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ " (mod ", frame_dtx_tchf_mod, ": ", fn mod frame_dtx_tchf_mod, ")",</span><br><span style="color: hsl(120, 100%, 40%);">+ " (mod ", block_dtx_tchf_mod, ": ", fn mod block_dtx_tchf_mod, ")");</span><br><span> f_rsl_chan_deact();</span><br><span> f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(0, 100%, 40%);">- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected L2 fill frame received on Um");</span><br><span> }</span><br><span> } else {</span><br><span> nfill_frames := nfill_frames + 1;</span><br><span>@@ -6807,9 +6806,9 @@</span><br><span> if (nfill_frames >= expected_fill_frames) {</span><br><span> setverdict(pass);</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- log("received only ", nfill_frames, " out of ",</span><br><span style="color: hsl(0, 100%, 40%);">- expected_fill_frames, " expected fill frames");</span><br><span style="color: hsl(0, 100%, 40%);">- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Not enough fill frames received");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Not enough fill frames received: ",</span><br><span style="color: hsl(120, 100%, 40%);">+ nfill_frames, " out of ", expected_fill_frames);</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span> } else {</span><br><span> repeat;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20888">change 20888</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20888"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I15f9303e79750c2864b97697b4378f748a1c7246 </div>
<div style="display:none"> Gerrit-Change-Number: 20888 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>