<p style="white-space: pre-wrap; word-wrap: break-word;">I checked your expression with a bit of math, don't know if it is correct, but it should be. num_meas_sub_expect is on both sides of the equation, so it should be possible to eliminate it.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20979">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20979/1/src/common/measurement.c">File src/common/measurement.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20979/1/src/common/measurement.c@645">Patch Set #1, Line 645:</a> <code style="font-family:monospace,monospace">                                if (num_meas_sub < num_meas_sub_expect</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">if (num_meas_sub <= i)</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20979/2/src/common/measurement.c">File src/common/measurement.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20979/2/src/common/measurement.c@645">Patch Set #2, Line 645:</a> <code style="font-family:monospace,monospace">                          if (num_meas_sub <= i) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I actually meant to change the second condition of the if iirc, so it shoudl actually be: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I have checked it this way:</p><p style="white-space: pre-wrap; word-wrap: break-word;">num_ul_meas_expect - i <= num_meas_sub_expect - num_meas_sub num_ul_meas_expect - i <= num_meas_sub_expect - num_meas_sub | - num_meas_sub_expect</p><ul><li>i <= - num_meas_sub | + i + num_meas_sub</li><li>num_meas_sub <= i</li></ul><p style="white-space: pre-wrap; word-wrap: break-word;">That isn't correct?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20979">change 20979</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20979"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I381cc637d1c125f279ccf88db114609946fe24fe </div>
<div style="display:none"> Gerrit-Change-Number: 20979 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 02 Nov 2020 16:03:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>