<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21012">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: fix missing / wrong documentation for some commands<br><br>Change-Id: Ie2f9e401c0f8f55307d98fa5afe5eb4182add43a<br>Related: SYS#4937, OS#3036<br>---<br>M src/common/vty.c<br>1 file changed, 18 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/21012/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index 288ac69..954e02c 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -490,7 +490,9 @@</span><br><span>              cfg_bts_rtp_jitbuf_cmd,</span><br><span>              X(BTS_VTY_ATTR_NEW_LCHAN),</span><br><span>           "rtp jitter-buffer <0-10000> [adaptive]",</span><br><span style="color: hsl(0, 100%, 40%);">-       RTP_STR "RTP jitter buffer\n" "jitter buffer in ms\n")</span><br><span style="color: hsl(120, 100%, 40%);">+            RTP_STR "RTP jitter buffer\n"</span><br><span style="color: hsl(120, 100%, 40%);">+       "Jitter buffer in ms\n"</span><br><span style="color: hsl(120, 100%, 40%);">+             "Enable adaptive RTP jitter buffering\n")</span><br><span> {</span><br><span>       struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -502,9 +504,10 @@</span><br><span> }</span><br><span> </span><br><span> DEFUN(cfg_bts_rtp_port_range,</span><br><span style="color: hsl(0, 100%, 40%);">-       cfg_bts_rtp_port_range_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-     "rtp port-range <1-65534> <1-65534>",</span><br><span style="color: hsl(0, 100%, 40%);">-      RTP_STR "Range of local ports to use for RTP/RTCP traffic\n")</span><br><span style="color: hsl(120, 100%, 40%);">+      cfg_bts_rtp_port_range_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+      "rtp port-range <1-65534> <1-65534>",</span><br><span style="color: hsl(120, 100%, 40%);">+      RTP_STR "Range of local ports to use for RTP/RTCP traffic\n"</span><br><span style="color: hsl(120, 100%, 40%);">+      "Port range start (inclusive)\n" "Port range end (inclusive)\n")</span><br><span> {</span><br><span>        struct gsm_bts *bts = vty->index;</span><br><span>         unsigned int start;</span><br><span>@@ -725,7 +728,8 @@</span><br><span> </span><br><span> DEFUN(cfg_bts_pcu_sock, cfg_bts_pcu_sock_cmd,</span><br><span>       "pcu-socket PATH",</span><br><span style="color: hsl(0, 100%, 40%);">-    "Configure the PCU socket file/path name\n")</span><br><span style="color: hsl(120, 100%, 40%);">+        "Configure the PCU socket file/path name\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "UNIX socket path\n")</span><br><span> {</span><br><span>         struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -759,9 +763,13 @@</span><br><span>      return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define SMSCB_STR \</span><br><span style="color: hsl(120, 100%, 40%);">+     "SMSCB (SMS Cell Broadcast) / CBCH configuration\n"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN_ATTR(cfg_bts_smscb_max_qlen, cfg_bts_smscb_max_qlen_cmd,</span><br><span>       "smscb queue-max-length <1-60>",</span><br><span style="color: hsl(0, 100%, 40%);">-        "Maximum queue length for SMSCB (CBCH) queue. In count of messages/pages (Default: 15)",</span><br><span style="color: hsl(120, 100%, 40%);">+    SMSCB_STR "Maximum length of the SMSCB (CBCH) queue\n"</span><br><span style="color: hsl(120, 100%, 40%);">+      "Length in count of messages/pages (default: 15)\n",</span><br><span>       CMD_ATTR_IMMEDIATE)</span><br><span> {</span><br><span>  struct gsm_bts *bts = vty->index;</span><br><span>@@ -771,7 +779,8 @@</span><br><span> </span><br><span> DEFUN_ATTR(cfg_bts_smscb_tgt_qlen, cfg_bts_smscb_tgt_qlen_cmd,</span><br><span>        "smscb queue-target-length <1-30>",</span><br><span style="color: hsl(0, 100%, 40%);">-     "Target queue length for SMSCB (CBCH) queue. In count of messages/pages (Default: 2)",</span><br><span style="color: hsl(120, 100%, 40%);">+      SMSCB_STR "Target length of the SMSCB (CBCH) queue\n"</span><br><span style="color: hsl(120, 100%, 40%);">+       "Length in count of messages/pages (default: 2)\n",</span><br><span>        CMD_ATTR_IMMEDIATE)</span><br><span> {</span><br><span>  struct gsm_bts *bts = vty->index;</span><br><span>@@ -781,7 +790,8 @@</span><br><span> </span><br><span> DEFUN_ATTR(cfg_bts_smscb_qhyst, cfg_bts_smscb_qhyst_cmd,</span><br><span>      "smscb queue-hysteresis <0-30>",</span><br><span style="color: hsl(0, 100%, 40%);">-        "Hysteresis for SMSCB (CBCH) queue. In count of messages/pages (Default: 2)",</span><br><span style="color: hsl(120, 100%, 40%);">+       SMSCB_STR "Hysteresis of the SMSCB (CBCH) queue\n"</span><br><span style="color: hsl(120, 100%, 40%);">+          "In count of messages/pages (default: 2)\n",</span><br><span>       CMD_ATTR_IMMEDIATE)</span><br><span> {</span><br><span>  struct gsm_bts *bts = vty->index;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21012">change 21012</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21012"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie2f9e401c0f8f55307d98fa5afe5eb4182add43a </div>
<div style="display:none"> Gerrit-Change-Number: 21012 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>