<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20938">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_l1_if: fix misaligned assignment of remote address<br><br>Found-by: asan<br>Change-Id: I9c87d3fc1b6f03d79b53f1da3a146630061c3459<br>---<br>M src/pcu_l1_if.cpp<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/38/20938/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp</span><br><span>index 4491c4e..8a825a1 100644</span><br><span>--- a/src/pcu_l1_if.cpp</span><br><span>+++ b/src/pcu_l1_if.cpp</span><br><span>@@ -507,7 +507,8 @@</span><br><span>                     local[i].u.sin.sin_port = htons(info_ind->local_port[i]);</span><br><span> </span><br><span>                     remote[i].u.sin.sin_family = AF_INET;</span><br><span style="color: hsl(0, 100%, 40%);">-                   remote[i].u.sin.sin_addr = info_ind->remote_ip[i].v4;</span><br><span style="color: hsl(120, 100%, 40%);">+                      memcpy(&remote[i].u.sin.sin_addr, &info_ind->remote_ip[i].v4,</span><br><span style="color: hsl(120, 100%, 40%);">+                             sizeof(struct in_addr));</span><br><span>                      remote[i].u.sin.sin_port = htons(info_ind->remote_port[i]);</span><br><span>                       break;</span><br><span>               case PCU_IF_ADDR_TYPE_IPV6:</span><br><span>@@ -516,7 +517,9 @@</span><br><span>                    local[i].u.sin6.sin6_port = htons(info_ind->local_port[i]);</span><br><span> </span><br><span>                   remote[i].u.sin6.sin6_family = AF_INET6;</span><br><span style="color: hsl(0, 100%, 40%);">-                        remote[i].u.sin6.sin6_addr = info_ind->remote_ip[i].v6;</span><br><span style="color: hsl(120, 100%, 40%);">+                    memcpy(&remote[i].u.sin6.sin6_addr,</span><br><span style="color: hsl(120, 100%, 40%);">+                              &info_ind->remote_ip[i].v6,</span><br><span style="color: hsl(120, 100%, 40%);">+                            sizeof(struct in6_addr));</span><br><span>                     remote[i].u.sin6.sin6_port = htons(info_ind->remote_port[i]);</span><br><span>                     break;</span><br><span>               default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20938">change 20938</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20938"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9c87d3fc1b6f03d79b53f1da3a146630061c3459 </div>
<div style="display:none"> Gerrit-Change-Number: 20938 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>