<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20930">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: Fix ws between if keyword and parenthesis<br><br>Change-Id: I5932f21c58e76552f7187a175b8e281c5846536c<br>---<br>M src/csn1.c<br>M src/encoding.cpp<br>M src/gsm_rlcmac.c<br>M src/pcu_vty_functions.cpp<br>M src/pdch.cpp<br>5 files changed, 11 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/20930/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.c b/src/csn1.c</span><br><span>index 5b60399..fa29e27 100644</span><br><span>--- a/src/csn1.c</span><br><span>+++ b/src/csn1.c</span><br><span>@@ -170,7 +170,7 @@</span><br><span> LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> /* end add the bit value to protocol tree */</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- else if(pDescr->may_be_null)</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (pDescr->may_be_null)</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = 0;</span><br><span>@@ -228,7 +228,7 @@</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span> bit_offset += no_of_bits;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- else if(pDescr->may_be_null)</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (pDescr->may_be_null)</span><br><span> {</span><br><span> if (no_of_bits <= 8)</span><br><span> {</span><br><span>@@ -1502,7 +1502,7 @@</span><br><span> LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> /* end add the bit value to protocol tree */</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- else if(pDescr->may_be_null)</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (pDescr->may_be_null)</span><br><span> {</span><br><span> LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);</span><br><span> }</span><br><span>@@ -1555,7 +1555,7 @@</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span> bit_offset += no_of_bits;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- else if(pDescr->may_be_null)</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (pDescr->may_be_null)</span><br><span> {</span><br><span> LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);</span><br><span> }</span><br><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index ecfca51..c6ec2e8 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -853,7 +853,7 @@</span><br><span> if (show_rbb[i] == 'R')</span><br><span> rbb_byte |= 1<< (7-(i%8));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if((i%8) == 7) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if ((i%8) == 7) {</span><br><span> rbb[i/8] = rbb_byte;</span><br><span> rbb_byte = 0;</span><br><span> }</span><br><span>diff --git a/src/gsm_rlcmac.c b/src/gsm_rlcmac.c</span><br><span>index 06c721e..abb1e59 100644</span><br><span>--- a/src/gsm_rlcmac.c</span><br><span>+++ b/src/gsm_rlcmac.c</span><br><span>@@ -6056,7 +6056,7 @@</span><br><span> LOGPC(DRLCMACDATA, LOGL_NOTICE, "E_1 = %u ", (unsigned)(data->E_1));</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if(data->E_1 == 0) // Extension octet follows immediately</span><br><span style="color: hsl(120, 100%, 40%);">+ if (data->E_1 == 0) // Extension octet follows immediately</span><br><span> {</span><br><span> // Octet 3 (optional)</span><br><span> i = 0;</span><br><span>@@ -6071,7 +6071,7 @@</span><br><span> i++;</span><br><span> } while((data->M[i-1] == 1)&&(data->E[i-1] == 0));</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- if(data->TI == 1) // TLLI field is present</span><br><span style="color: hsl(120, 100%, 40%);">+ if (data->TI == 1) // TLLI field is present</span><br><span> {</span><br><span> data->TLLI = bitvec_read_field(vector, &readIndex, 32);</span><br><span> LOGPC(DRLCMACDATA, LOGL_NOTICE, "TLLI = %08x ", data->TLLI);</span><br><span>@@ -6132,7 +6132,7 @@</span><br><span> LOGPC(DRLCMACDATA, LOGL_NOTICE, "E_1 = %u ", (unsigned)(data->E_1));</span><br><span> </span><br><span> // Octet 3 (optional)</span><br><span style="color: hsl(0, 100%, 40%);">- if(data->E_1 == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (data->E_1 == 0)</span><br><span> {</span><br><span> i = 0;</span><br><span> do</span><br><span>diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp</span><br><span>index 28a1559..416c006 100644</span><br><span>--- a/src/pcu_vty_functions.cpp</span><br><span>+++ b/src/pcu_vty_functions.cpp</span><br><span>@@ -79,7 +79,7 @@</span><br><span> ul_tbf->window_size(), win->v_q(), win->v_r());</span><br><span> vty_out(vty, "%s", VTY_NEWLINE);</span><br><span> vty_out(vty, " TBF Statistics:%s", VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">- if(GPRS == tbf->ms()->mode()) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (GPRS == tbf->ms()->mode()) {</span><br><span> vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_gprs_ctrs);</span><br><span> } else {</span><br><span> vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_egprs_ctrs);</span><br><span>@@ -92,7 +92,7 @@</span><br><span> win->window_stalled() ? " STALLED" : "");</span><br><span> vty_out(vty, "%s", VTY_NEWLINE);</span><br><span> vty_out_rate_ctr_group(vty, " ", tbf->m_ctrs);</span><br><span style="color: hsl(0, 100%, 40%);">- if(GPRS == tbf->ms()->mode()) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (GPRS == tbf->ms()->mode()) {</span><br><span> vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_gprs_ctrs);</span><br><span> } else {</span><br><span> vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_egprs_ctrs);</span><br><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index e4ea853..ff13477 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -704,7 +704,7 @@</span><br><span> else</span><br><span> bts()->send_gsmtap_meas(PCU_GSMTAP_C_UL_CTRL, true, trx_no(), ts_no, GSMTAP_CHANNEL_PACCH, fn, data, data_len, meas);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if(rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc < 0) {</span><br><span> LOGP(DRLCMACUL, LOGL_ERROR, "Dropping Uplink Control Block with invalid "</span><br><span> "content, decode failed: %d)\n", rc);</span><br><span> goto free_ret;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20930">change 20930</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20930"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5932f21c58e76552f7187a175b8e281c5846536c </div>
<div style="display:none"> Gerrit-Change-Number: 20930 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>