<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20933">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, but someone else must approve
  lynxis lazus: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: remove the nsvc fsm timer when cleaning up the fsm<br><br>Change-Id: I9c7f767077ed2e354d0980a9f11246c1151c65e2<br>---<br>M src/gb/gprs_ns2_vc_fsm.c<br>1 file changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>index d13f1ce..451437f 100644</span><br><span>--- a/src/gb/gprs_ns2_vc_fsm.c</span><br><span>+++ b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>@@ -540,6 +540,14 @@</span><br><span>   }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void gprs_ns2_vc_fsm_clean(struct osmo_fsm_inst *fi,</span><br><span style="color: hsl(120, 100%, 40%);">+                                 enum osmo_fsm_term_cause cause)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gprs_ns2_vc_priv *priv = fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        osmo_timer_del(&priv->alive.timer);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static struct osmo_fsm gprs_ns2_vc_fsm = {</span><br><span>        .name = "GPRS-NS2-VC",</span><br><span>     .states = gprs_ns2_vc_states,</span><br><span>@@ -549,7 +557,7 @@</span><br><span>                         S(GPRS_NS2_EV_ALIVE) |</span><br><span>                               S(GPRS_NS2_EV_ALIVE_ACK),</span><br><span>     .allstate_action = gprs_ns2_vc_fsm_allstate_action,</span><br><span style="color: hsl(0, 100%, 40%);">-     .cleanup = NULL,</span><br><span style="color: hsl(120, 100%, 40%);">+      .cleanup = gprs_ns2_vc_fsm_clean,</span><br><span>    .timer_cb = gprs_ns2_vc_fsm_timer_cb,</span><br><span>        /* .log_subsys = DNS, "is not constant" */</span><br><span>         .event_names = gprs_ns2_vc_event_names,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20933">change 20933</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20933"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9c7f767077ed2e354d0980a9f11246c1151c65e2 </div>
<div style="display:none"> Gerrit-Change-Number: 20933 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>