<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20887">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests/DTX: SACCH has nothing to do with fill frames<br><br>There is no such thing like a fill frame on SACCH:<br><br> - on Downlink, it's always System Information messages;<br> - on Uplink, it's always the Measurement Reports.<br><br>Yes, osmo-bts-trx does send dummy LAPDm func=UI frames on SACCH,<br>but this happens because the test suite never feds it with the<br>associated System Information messages (i.e. Type 5, 5ter, 6).<br><br>In the 'alt' statement, restrict matching of L1CTL DATA.ind, so<br>only DCCH/FACCH blocks are counted. Ignore DL SACCH blocks.<br><br>This change reveals that TC_tch_sign_l2_fill_frame_dtxd actually<br>fails because no fill frames are received at all from the IUT.<br><br>Change-Id: I6c68dd0a7dfa18ae4573a037399b6650feb22f11<br>Related: OS#4801<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 21 insertions(+), 38 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/20887/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index fa6ca0c..5a701e0 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -6707,12 +6707,9 @@</span><br><span> ***********************************************************************/</span><br><span> private function f_test_l2_fill_frames(boolean dtxd) runs on ConnHdlr {</span><br><span> var L1ctlDlMessage dl;</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring l2_fill_frame := '0303012B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O;</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring l2_fill_frame_sacch := substr(l2_fill_frame, 0, lengthof(l2_fill_frame) - 2);</span><br><span> var GsmFrameNumber first_fn;</span><br><span> var boolean is_first_frame := true;</span><br><span style="color: hsl(0, 100%, 40%);">- var integer nfill_frames_sacch := 0;</span><br><span style="color: hsl(0, 100%, 40%);">- var integer nfill_frames_nonsacch := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer nfill_frames := 0;</span><br><span> var integer expected_fill_frames := 10000; /* initial value causes test failure if not overridden */</span><br><span> /* Frames numbers (mod 104) for which a fill frame is expected on TCHF if DTX is enabled. */</span><br><span> var Integers required_tdma_frames_dtx_tchf := { 52, 53, 54, 55, 56, 57, 58, 59 };</span><br><span>@@ -6730,26 +6727,21 @@</span><br><span> /* activate TCHF signalling channel */</span><br><span> f_est_dchan(false);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* A template for matching dummy LAPDm func=UA frames */</span><br><span style="color: hsl(120, 100%, 40%);">+ var template L1ctlDlMessage tr_fill_frame := tr_L1CTL_DATA_IND(</span><br><span style="color: hsl(120, 100%, 40%);">+ chan_nr := g_chan_nr, link_id := tr_RslLinkID_DCCH(?),</span><br><span style="color: hsl(120, 100%, 40%);">+ l2_data := f_pad_oct('030301'O, 23, '2B'O));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> T.start;</span><br><span> alt {</span><br><span style="color: hsl(0, 100%, 40%);">- [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, ?)) -> value dl {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] L1CTL.receive(tr_fill_frame) -> value dl {</span><br><span> var GsmFrameNumber fn := dl.dl_info.frame_nr;</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring l2 := dl.payload.data_ind.payload;</span><br><span> </span><br><span> if (is_first_frame) {</span><br><span> is_first_frame := false;</span><br><span> first_fn := dl.dl_info.frame_nr;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (dl.dl_info.link_id.c == SACCH) {</span><br><span style="color: hsl(0, 100%, 40%);">- l2 := substr(l2, 2, lengthof(l2) - 2); /* remove L1 header */</span><br><span style="color: hsl(0, 100%, 40%);">- if (not match(l2_fill_frame_sacch, l2)) {</span><br><span style="color: hsl(0, 100%, 40%);">- repeat;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } else if (not match(l2_fill_frame, l2)) {</span><br><span style="color: hsl(0, 100%, 40%);">- repeat;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> if (dtxd) {</span><br><span> if (not match(g_chan_nr, t_RslChanNr_Bm(?))) {</span><br><span> T.stop;</span><br><span>@@ -6762,29 +6754,24 @@</span><br><span> f_rsl_chan_deact();</span><br><span> f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* With DTX enabled we can expect at least 3 fill frames for every 104 frames.</span><br><span style="color: hsl(0, 100%, 40%);">- * 2 SACCH, 1 TCH/F */</span><br><span style="color: hsl(0, 100%, 40%);">- expected_fill_frames := 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* With DTX enabled we can expect at least 3 fill frames for every 104 frames. */</span><br><span style="color: hsl(120, 100%, 40%);">+ expected_fill_frames := 2;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (nfill_frames_sacch + nfill_frames_nonsacch < expected_fill_frames) {</span><br><span style="color: hsl(0, 100%, 40%);">- log("received only ", nfill_frames_sacch, "+", nfill_frames_nonsacch,</span><br><span style="color: hsl(0, 100%, 40%);">- " (SACCH+other) out of ", expected_fill_frames, " expected fill frames");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nfill_frames < expected_fill_frames) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("received only ", nfill_frames, " out of ",</span><br><span style="color: hsl(120, 100%, 40%);">+ expected_fill_frames, " expected fill frames");</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Not enough fill frames received");</span><br><span> } else {</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- if (dl.dl_info.link_id.c == SACCH) {</span><br><span style="color: hsl(0, 100%, 40%);">- nfill_frames_sacch := nfill_frames_sacch + 1;</span><br><span style="color: hsl(0, 100%, 40%);">- repeat;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> /* On DTX TCH/F channels, fill frames occur only for specific frame numbers mod 104.</span><br><span> * Furthermore, the L1SAP layer gives us frame numbers for the start of a block so</span><br><span> * we should only see the subset of frames numbers which correspond to a block boundary.</span><br><span> * TCH/F blocks are defined to start at 0,4,8,13,17,21 (modulo 26) */</span><br><span> for (var integer i := 0; i < lengthof(required_tdma_blocks_dtx_tchf); i := i + 1) {</span><br><span> if (fn mod frame_dtx_tchf_mod == required_tdma_blocks_dtx_tchf[i]) {</span><br><span style="color: hsl(0, 100%, 40%);">- nfill_frames_nonsacch := nfill_frames_nonsacch + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ nfill_frames := nfill_frames + 1;</span><br><span> repeat;</span><br><span> }</span><br><span> }</span><br><span>@@ -6796,22 +6783,18 @@</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected L2 fill frame received on Um");</span><br><span> }</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- if (dl.dl_info.link_id.c == SACCH) {</span><br><span style="color: hsl(0, 100%, 40%);">- nfill_frames_sacch := nfill_frames_sacch + 1;</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- nfill_frames_nonsacch := nfill_frames_nonsacch + 1;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ nfill_frames := nfill_frames + 1;</span><br><span> if (fn > first_fn + frame_dtx_tchf_mod) {</span><br><span> T.stop;</span><br><span> </span><br><span> select (g_chan_nr) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* TCH/F: we expect 25 fill frames (24 FACCH + 1 SACCH) for every 104 frames. */</span><br><span style="color: hsl(0, 100%, 40%);">- case (t_RslChanNr_Bm(?)) { expected_fill_frames := 25; }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TCH/F: we expect 24 fill frames for every 104 frames. */</span><br><span style="color: hsl(120, 100%, 40%);">+ case (t_RslChanNr_Bm(?)) { expected_fill_frames := 24; }</span><br><span> /* TCH/H: we expect 2 fill frames for every 104 frames. */</span><br><span> case (t_RslChanNr_Lm(?, ?)) { expected_fill_frames := 2; }</span><br><span> /* SDCCH: we expect 5 fill frames for every 104 frames. */</span><br><span style="color: hsl(0, 100%, 40%);">- case (t_RslChanNr_SDCCH4(?, ?)) { expected_fill_frames := 5; }</span><br><span style="color: hsl(0, 100%, 40%);">- case (t_RslChanNr_SDCCH8(?, ?)) { expected_fill_frames := 5; }</span><br><span style="color: hsl(120, 100%, 40%);">+ case (t_RslChanNr_SDCCH4(?, ?)) { expected_fill_frames := 4; }</span><br><span style="color: hsl(120, 100%, 40%);">+ case (t_RslChanNr_SDCCH8(?, ?)) { expected_fill_frames := 4; }</span><br><span> case else {</span><br><span> /* This shall not happen, just to be sure */</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span>@@ -6821,11 +6804,11 @@</span><br><span> f_rsl_chan_deact();</span><br><span> f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (nfill_frames_sacch + nfill_frames_nonsacch >= expected_fill_frames) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nfill_frames >= expected_fill_frames) {</span><br><span> setverdict(pass);</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- log("received only ", nfill_frames_sacch, "+", nfill_frames_nonsacch,</span><br><span style="color: hsl(0, 100%, 40%);">- " (SACCH+other) out of ", expected_fill_frames, " expected fill frames");</span><br><span style="color: hsl(120, 100%, 40%);">+ log("received only ", nfill_frames, " out of ",</span><br><span style="color: hsl(120, 100%, 40%);">+ expected_fill_frames, " expected fill frames");</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Not enough fill frames received");</span><br><span> }</span><br><span> } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20887">change 20887</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20887"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6c68dd0a7dfa18ae4573a037399b6650feb22f11 </div>
<div style="display:none"> Gerrit-Change-Number: 20887 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>