<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20826">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">oml: Set NM_OPSTATE_DISABLED by default<br><br>Otherwise, some objects are announced at startup of osmo-bts towards BSC<br>during State Changed Report as being "NULL".<br><br>According to TS 12.21:<br>"NULL(Operat. state not supported) FF"<br><br>Which doesn't make much sense in startup situation. They are in known<br>state Disabled until they are OPSTARTed.<br><br>Change-Id: I5ba6756ea069d0f995f453ee4b27e6839c914eb1<br>---<br>M src/common/bts.c<br>M src/common/oml.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/bts.c b/src/common/bts.c</span><br><span>index a1f29ff..6c25cbd 100644</span><br><span>--- a/src/common/bts.c</span><br><span>+++ b/src/common/bts.c</span><br><span>@@ -356,9 +356,9 @@</span><br><span>    oml_mo_state_init(&bts->mo, NM_OPSTATE_DISABLED, NM_AVSTATE_NOT_INSTALLED);</span><br><span> </span><br><span>       /* set BTS attr to dependency */</span><br><span style="color: hsl(0, 100%, 40%);">-        oml_mo_state_init(&bts->gprs.nse.mo, -1, NM_AVSTATE_DEPENDENCY);</span><br><span style="color: hsl(0, 100%, 40%);">- oml_mo_state_init(&bts->gprs.cell.mo, -1, NM_AVSTATE_DEPENDENCY);</span><br><span style="color: hsl(0, 100%, 40%);">-        oml_mo_state_init(&bts->gprs.nsvc[0].mo, -1, NM_AVSTATE_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+   oml_mo_state_init(&bts->gprs.nse.mo, NM_OPSTATE_DISABLED, NM_AVSTATE_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+      oml_mo_state_init(&bts->gprs.cell.mo, NM_OPSTATE_DISABLED, NM_AVSTATE_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+     oml_mo_state_init(&bts->gprs.nsvc[0].mo, NM_OPSTATE_DISABLED, NM_AVSTATE_DEPENDENCY);</span><br><span>         oml_mo_state_init(&bts->gprs.nsvc[1].mo, NM_OPSTATE_DISABLED, NM_AVSTATE_OFF_LINE);</span><br><span> </span><br><span>       /* allocate a talloc pool for ORTP to ensure it doesn't have to go back</span><br><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index e48f943..02b1770 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -1562,7 +1562,7 @@</span><br><span>     mo->obj_inst.bts_nr = p1;</span><br><span>         mo->obj_inst.trx_nr = p2;</span><br><span>         mo->obj_inst.ts_nr = p3;</span><br><span style="color: hsl(0, 100%, 40%);">-     mo->nm_state.operational = NM_OPSTATE_NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+        mo->nm_state.operational = NM_OPSTATE_DISABLED;</span><br><span>   mo->nm_state.availability = NM_AVSTATE_POWER_OFF;</span><br><span>         mo->nm_state.administrative = NM_STATE_LOCKED;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20826">change 20826</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20826"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5ba6756ea069d0f995f453ee4b27e6839c914eb1 </div>
<div style="display:none"> Gerrit-Change-Number: 20826 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>