<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20839">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: add FAACH to TC_meas_res_speech_tchX<br><br>The current TC_meas_res_speech_tchX tests only test a pure voice<br>transmission. A voice transmission can be occasionally interrupted by<br>FACCH transmissions. This should also be tested. Lets ad a _facch<br>variant for the two speech test variants we already that injects a FACCH<br>from time to time.<br><br>Related: OS#4799<br>Change-Id: Ie9cd39739d4b972f4e533a7bc90f79e914888aab<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 39 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 09a7a15..cfb49dc 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -751,7 +751,8 @@</span><br><span> timing_offset_256syms := mp_timing_offset_256syms_exp,</span><br><span> bs_power_level := 0,</span><br><span> ms_power_level := mp_ms_power_level_exp,</span><br><span style="color: hsl(0, 100%, 40%);">- ms_actual_ta := mp_ms_actual_ta_exp</span><br><span style="color: hsl(120, 100%, 40%);">+ ms_actual_ta := mp_ms_actual_ta_exp,</span><br><span style="color: hsl(120, 100%, 40%);">+ facch_enabled := false</span><br><span> },</span><br><span> spec := omit,</span><br><span> encr := omit,</span><br><span>@@ -1788,8 +1789,17 @@</span><br><span> var L1ctlDlMessage l1_dl;</span><br><span> [] L1CTL.receive(tr_L1CTL_TRAFFIC_IND(g_chan_nr)) -> value l1_dl {</span><br><span> log("TCH received: ", l1_dl.payload.traffic_ind.data);</span><br><span style="color: hsl(0, 100%, 40%);">- L1CTL.send(ts_L1CTL_TRAFFIC_REQ(g_chan_nr, l1_dl.dl_info.link_id,</span><br><span style="color: hsl(0, 100%, 40%);">- l1_dl.payload.traffic_ind.data));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* occasionaly inject FACCH frames into the uplink */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (g_pars.l1_pars.facch_enabled == true and l1_dl.dl_info.frame_nr mod 5 == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring pl := '010301'O;</span><br><span style="color: hsl(120, 100%, 40%);">+ L1CTL.send(ts_L1CTL_DATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0),</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pad_oct(pl, 23, '2B'O)));</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ L1CTL.send(ts_L1CTL_TRAFFIC_REQ(g_chan_nr, l1_dl.dl_info.link_id,</span><br><span style="color: hsl(120, 100%, 40%);">+ l1_dl.payload.traffic_ind.data));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> repeat;</span><br><span> }</span><br><span> }</span><br><span>@@ -1811,7 +1821,8 @@</span><br><span> int16_t timing_offset_256syms,</span><br><span> uint4_t bs_power_level,</span><br><span> uint5_t ms_power_level,</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t ms_actual_ta</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t ms_actual_ta,</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean facch_enabled</span><br><span> }</span><br><span> </span><br><span> /* Convert tiing offset from 1/256th symbol to RSL Timing Offset */</span><br><span>@@ -2976,7 +2987,7 @@</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-testcase TC_meas_res_speech_tchf() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_TC_meas_res_speech_tchf(boolean facch_enabled) runs on test_CT {</span><br><span> var template RSL_IE_ChannelMode ch_mode;</span><br><span> var ConnHdlr vc_conn;</span><br><span> var ConnHdlrPars pars;</span><br><span>@@ -2984,13 +2995,23 @@</span><br><span> ch_mode := ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM1);</span><br><span> for (var integer tn := 1; tn <= 1; tn := tn + 1) {</span><br><span> pars := valueof(t_Pars(t_RslChanNr_Bm(tn), ch_mode));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars.l1_pars.facch_enabled := facch_enabled;</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars,</span><br><span> pcu_comp := false, trxc_comp := true);</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-testcase TC_meas_res_speech_tchh() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_meas_res_speech_tchf() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_TC_meas_res_speech_tchf(false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_meas_res_speech_tchf_facch() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_TC_meas_res_speech_tchf(true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_TC_meas_res_speech_tchh(boolean facch_enabled) runs on test_CT {</span><br><span> var template RSL_IE_ChannelMode ch_mode;</span><br><span> var ConnHdlr vc_conn;</span><br><span> var ConnHdlrPars pars;</span><br><span>@@ -2998,12 +3019,22 @@</span><br><span> ch_mode := ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM1);</span><br><span> for (var integer ss := 0; ss <= 1; ss := ss + 1) {</span><br><span> pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ch_mode));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars.l1_pars.facch_enabled := facch_enabled;</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars,</span><br><span> pcu_comp := false, trxc_comp := true);</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_meas_res_speech_tchh() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_TC_meas_res_speech_tchh(false)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_meas_res_speech_tchh_facch() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_TC_meas_res_speech_tchh(true)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> testcase TC_meas_res_speech_tchh_toa256() runs on test_CT {</span><br><span> var template RSL_IE_ChannelMode ch_mode;</span><br><span> var ConnHdlr vc_conn;</span><br><span>@@ -7185,7 +7216,9 @@</span><br><span> execute( TC_rach_load_idle_below_thresh() );</span><br><span> execute( TC_rach_load_count() );</span><br><span> execute( TC_meas_res_speech_tchf() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_meas_res_speech_tchf_facch() );</span><br><span> execute( TC_meas_res_speech_tchh() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_meas_res_speech_tchh_facch() );</span><br><span> execute( TC_meas_res_speech_tchh_toa256() );</span><br><span> execute( TC_meas_res_sign_tchf() );</span><br><span> execute( TC_meas_res_sign_tchh() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20839">change 20839</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20839"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie9cd39739d4b972f4e533a7bc90f79e914888aab </div>
<div style="display:none"> Gerrit-Change-Number: 20839 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>