<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20824">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts_trx.c: Dispatch missing NM_EV_RSL_UP/DOWN to the bb_transc object<br><br>Previous commit 7810a917331b33b6cfab5259b5fb2df73b27b230 forgot to<br>introduce this line, though it was planned to be there.<br><br>Most of the time it worked fine anyway because the RSL link is not the last<br>event bb_transc waits for before switching to Enabled, so later events<br>would trigger inside the bb_transc fsm a recheck (polling) which wuld<br>allow to advance to Enabled state.<br>However, in the situation where RSL link UP is the last event to happen,<br>no more inside-FSM checks are triggered and hence BB Transeiver never<br>goes to Enabled state, and as a result no event is triggered towards<br>each RadioChannel which in turn don't go to Enabled state.<br><br>Fixes: 7810a917331b33b6cfab5259b5fb2df73b27b230<br>Change-Id: I8c777b946e7abcb4b607ec4d136c981a0716b120<br>---<br>M src/common/bts_trx.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/bts_trx.c b/src/common/bts_trx.c</span><br><span>index 6bb18a3..38fb90a 100644</span><br><span>--- a/src/common/bts_trx.c</span><br><span>+++ b/src/common/bts_trx.c</span><br><span>@@ -199,6 +199,7 @@</span><br><span>              link ? "up" : "down");</span><br><span> </span><br><span>       osmo_fsm_inst_dispatch(trx->mo.fi, link ? NM_EV_RSL_UP : NM_EV_RSL_DOWN, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+    osmo_fsm_inst_dispatch(trx->bb_transc.mo.fi, link ? NM_EV_RSL_UP : NM_EV_RSL_DOWN, NULL);</span><br><span> </span><br><span>     if (link)</span><br><span>            rc = rsl_tx_rf_res(trx);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20824">change 20824</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20824"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8c777b946e7abcb4b607ec4d136c981a0716b120 </div>
<div style="display:none"> Gerrit-Change-Number: 20824 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>