<p>keith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20798">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  keith: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">VTY: Add gtp state-dir command<br><br>The SGSN initialises GTP with gtp_statedir of "./" which may<br>not be the desired path for writing the gsn_restart file.<br>When starting from systemd for example, we might write<br>to the system root.<br><br>This patch allows override via the config file.<br><br>Closes: OS#4820<br>Change-Id: Ib3ffb7fd6ea1d9b0286111d8c2cba9da5394ca58<br>---<br>M src/sgsn/sgsn_vty.c<br>M tests/test_nodes.vty<br>2 files changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c</span><br><span>index 14248d1..33a652c 100644</span><br><span>--- a/src/sgsn/sgsn_vty.c</span><br><span>+++ b/src/sgsn/sgsn_vty.c</span><br><span>@@ -186,6 +186,8 @@</span><br><span> </span><br><span>      vty_out(vty, "sgsn%s", VTY_NEWLINE);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    vty_out(vty, " gtp state-dir %s%s",</span><br><span style="color: hsl(120, 100%, 40%);">+         g_cfg->gtp_statedir, VTY_NEWLINE);</span><br><span>        vty_out(vty, " gtp local-ip %s%s",</span><br><span>                 inet_ntoa(g_cfg->gtp_listenaddr.sin_addr), VTY_NEWLINE);</span><br><span> </span><br><span>@@ -315,6 +317,17 @@</span><br><span>       return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_sgsn_state_dir, cfg_sgsn_state_dir_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+       "gtp state-dir PATH",</span><br><span style="color: hsl(120, 100%, 40%);">+       "GTP Parameters\n"</span><br><span style="color: hsl(120, 100%, 40%);">+  "Set the directory for the GTP State file\n"</span><br><span style="color: hsl(120, 100%, 40%);">+        "Local Directory\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     osmo_talloc_replace_string(sgsn, &sgsn->cfg.gtp_statedir, argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(cfg_sgsn_bind_addr, cfg_sgsn_bind_addr_cmd,</span><br><span>        "gtp local-ip A.B.C.D",</span><br><span>    "GTP Parameters\n"</span><br><span>@@ -1432,6 +1445,7 @@</span><br><span> </span><br><span>     install_element(CONFIG_NODE, &cfg_sgsn_cmd);</span><br><span>     install_node(&sgsn_node, config_write_sgsn);</span><br><span style="color: hsl(120, 100%, 40%);">+      install_element(SGSN_NODE, &cfg_sgsn_state_dir_cmd);</span><br><span>     install_element(SGSN_NODE, &cfg_sgsn_bind_addr_cmd);</span><br><span>     install_element(SGSN_NODE, &cfg_ggsn_remote_ip_cmd);</span><br><span>     //install_element(SGSN_NODE, &cfg_ggsn_remote_port_cmd);</span><br><span>diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty</span><br><span>index 18bccc8..109e2ec 100644</span><br><span>--- a/tests/test_nodes.vty</span><br><span>+++ b/tests/test_nodes.vty</span><br><span>@@ -27,6 +27,7 @@</span><br><span> OsmoSGSN(config)# sgsn</span><br><span> OsmoSGSN(config-sgsn)# list</span><br><span> ...</span><br><span style="color: hsl(120, 100%, 40%);">+  gtp state-dir PATH</span><br><span>   gtp local-ip A.B.C.D</span><br><span>   ggsn <0-255> remote-ip A.B.C.D</span><br><span>   ggsn <0-255> gtp-version (0|1)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20798">change 20798</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20798"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib3ffb7fd6ea1d9b0286111d8c2cba9da5394ca58 </div>
<div style="display:none"> Gerrit-Change-Number: 20798 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>