<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/20808">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">remsim-client: Avoid zombies when scripts terminate<br><br>This avoids the OS from keeping terminated children (scripts) around<br>as zombies.<br><br>Change-Id: If7d45bda160987a26c7b101db6152142dc432fe7<br>---<br>M src/client/remsim_client_main.c<br>1 file changed, 20 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c</span><br><span>index bc916b9..bbc2990 100644</span><br><span>--- a/src/client/remsim_client_main.c</span><br><span>+++ b/src/client/remsim_client_main.c</span><br><span>@@ -1,4 +1,5 @@</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <errno.h></span><br><span> #include <signal.h></span><br><span> #include <unistd.h></span><br><span> #define _GNU_SOURCE</span><br><span>@@ -142,6 +143,19 @@</span><br><span>         }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int avoid_zombies(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+       static struct sigaction sa_chld;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    sa_chld.sa_handler = SIG_IGN;</span><br><span style="color: hsl(120, 100%, 40%);">+ sigemptyset(&sa_chld.sa_mask);</span><br><span style="color: hsl(120, 100%, 40%);">+    sa_chld.sa_flags = SA_NOCLDWAIT;</span><br><span style="color: hsl(120, 100%, 40%);">+      sa_chld.sa_restorer = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return sigaction(SIGCHLD, &sa_chld, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int main(int argc, char **argv)</span><br><span> {</span><br><span>  struct bankd_client *g_client;</span><br><span>@@ -166,6 +180,12 @@</span><br><span> </span><br><span>    signal(SIGUSR1, handle_sig_usr1);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Silently (and portably) reap children. */</span><br><span style="color: hsl(120, 100%, 40%);">+  if (avoid_zombies() < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+         fprintf(stderr, "Unable to silently reap children: %s\n", strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+         exit(1);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  asn_debug = 0;</span><br><span> </span><br><span>   client_user_main(g_client);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/20808">change 20808</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/20808"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If7d45bda160987a26c7b101db6152142dc432fe7 </div>
<div style="display:none"> Gerrit-Change-Number: 20808 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>