<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20789">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Log error if pdp ctx is freed while holding an active timer<br><br>Change-Id: Iae520be36377b27a12441defa722fd41a3cdba0a<br>---<br>M src/sgsn/gprs_sgsn.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/89/20789/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c</span><br><span>index cb2c0fc..0b7c21e 100644</span><br><span>--- a/src/sgsn/gprs_sgsn.c</span><br><span>+++ b/src/sgsn/gprs_sgsn.c</span><br><span>@@ -511,6 +511,11 @@</span><br><span>    sig_data.pdp = pdp;</span><br><span>  osmo_signal_dispatch(SS_SGSN, S_SGSN_PDP_FREE, &sig_data);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    if (osmo_timer_pending(&pdp->timer)) {</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGPDPCTXP(LOGL_ERROR, pdp, "Freeing PDP ctx with timer %u pending\n", pdp->T);</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_timer_del(&pdp->timer);</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  rate_ctr_group_free(pdp->ctrg);</span><br><span>   if (pdp->mm)</span><br><span>              llist_del(&pdp->list);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20789">change 20789</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20789"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iae520be36377b27a12441defa722fd41a3cdba0a </div>
<div style="display:none"> Gerrit-Change-Number: 20789 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>