<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20645">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: fix CHANnel ACTIVation message in TC_meas_res_sign_tchX<br><br>The testcase TC_meas_res_sign_tchX activates a traffic channel in<br>signalling mode and checks the RSL resulting measurement reports.<br><br>The CHANnel ACTIVation message sets "SDCCH" as "Channel rate and Type"<br>value. This is invalid, the "Channel Rate and Type" sould be set to "Half /<br>Full rate TCH Channel Lm / Bm" (while the speech or data indicator is<br>still set to "Signalling")<br><br>Change-Id: I51887b0d0379fcc1f4483d08dfdd6869e7a9f963<br>Related: OS#4799<br>---<br>M bts/BTS_Tests.ttcn<br>M library/RSL_Types.ttcn<br>2 files changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 4128406..1a6cca3 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -3010,7 +3010,7 @@</span><br><span> var ConnHdlrPars pars;</span><br><span> f_init();</span><br><span> for (var integer tn := 1; tn <= 4; tn := tn+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- pars := valueof(t_Pars(t_RslChanNr_Bm(tn), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(t_RslChanNr_Bm(tn), ts_RSL_ChanMode_SIGN(false, RSL_CHRT_TCH_F)));</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars,</span><br><span> pcu_comp := false, trxc_comp := true);</span><br><span> vc_conn.done;</span><br><span>@@ -3022,7 +3022,7 @@</span><br><span> var ConnHdlrPars pars;</span><br><span> f_init();</span><br><span> for (var integer ss := 0; ss <= 1; ss := ss+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN(false, RSL_CHRT_TCH_H)));</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars,</span><br><span> pcu_comp := false, trxc_comp := true);</span><br><span> vc_conn.done;</span><br><span>@@ -3059,7 +3059,7 @@</span><br><span> f_init();</span><br><span> f_vty_config(BTSVTY, "bts 0", "supp-meas-info toa256");</span><br><span> for (var integer ss := 0; ss <= 1; ss := ss+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN(false, RSL_CHRT_TCH_H)));</span><br><span> pars.l1_pars.toa256_enabled := true;</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars);</span><br><span> vc_conn.done;</span><br><span>diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn</span><br><span>index 05effa2..ff60a37 100644</span><br><span>--- a/library/RSL_Types.ttcn</span><br><span>+++ b/library/RSL_Types.ttcn</span><br><span>@@ -397,13 +397,14 @@</span><br><span> RSL_SpeechAlgo coding_alg_rate</span><br><span> } with { variant (len) "LENGTHTO(reserved,dtx_d,dtx_u,spd_ind,ch_rate_type,coding_alg_rate)" }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- template (value) RSL_IE_ChannelMode ts_RSL_ChanMode_SIGN(boolean dtx_downlink := false) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_ChannelMode ts_RSL_ChanMode_SIGN(boolean dtx_downlink := false,</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL_ChanRateType t := RSL_CHRT_SDCCH) := {</span><br><span> len := 0, /* overwritten */</span><br><span> reserved := '000000'B,</span><br><span> dtx_d := dtx_downlink,</span><br><span> dtx_u := false,</span><br><span> spd_ind := RSL_SPDI_SIGN,</span><br><span style="color: hsl(0, 100%, 40%);">- ch_rate_type := RSL_CHRT_SDCCH,</span><br><span style="color: hsl(120, 100%, 40%);">+ ch_rate_type := t,</span><br><span> coding_alg_rate := RSL_CMOD_NO_RESOURCE</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20645">change 20645</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20645"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I51887b0d0379fcc1f4483d08dfdd6869e7a9f963 </div>
<div style="display:none"> Gerrit-Change-Number: 20645 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>