<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/20762">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Lint fixes: false -> False, missing imports, Index list, not map iter<br><br>Change-Id: Iff4123a49c8dbcfc405612c0663d5c7d0f549748<br>---<br>M pySim-prog.py<br>M pySim/transport/pcsc.py<br>M pySim/utils.py<br>3 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/20762/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-prog.py b/pySim-prog.py</span><br><span>index f2d3676..942cfb0 100755</span><br><span>--- a/pySim-prog.py</span><br><span>+++ b/pySim-prog.py</span><br><span>@@ -647,13 +647,13 @@</span><br><span>           if opts.read_iccid:</span><br><span>                  if opts.dry_run:</span><br><span>                             # Connect transport</span><br><span style="color: hsl(0, 100%, 40%);">-                             card_handler.get(false)</span><br><span style="color: hsl(120, 100%, 40%);">+                               card_handler.get(False)</span><br><span>                      (res,_) = scc.read_binary(['3f00', '2fe2'], length=10)</span><br><span>                       iccid = dec_iccid(res)</span><br><span>               elif opts.read_imsi:</span><br><span>                         if opts.dry_run:</span><br><span>                             # Connect transport</span><br><span style="color: hsl(0, 100%, 40%);">-                             card_handler.get(false)</span><br><span style="color: hsl(120, 100%, 40%);">+                               card_handler.get(False)</span><br><span>                      (res,_) = scc.read_binary(EF['IMSI'])</span><br><span>                        imsi = swap_nibbles(res)[3:]</span><br><span>                 else:</span><br><span>diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py</span><br><span>index 4775a1b..7b50869 100644</span><br><span>--- a/pySim/transport/pcsc.py</span><br><span>+++ b/pySim/transport/pcsc.py</span><br><span>@@ -24,10 +24,10 @@</span><br><span> </span><br><span> from smartcard.CardConnection import CardConnection</span><br><span> from smartcard.CardRequest import CardRequest</span><br><span style="color: hsl(0, 100%, 40%);">-from smartcard.Exceptions import NoCardException, CardRequestTimeoutException</span><br><span style="color: hsl(120, 100%, 40%);">+from smartcard.Exceptions import NoCardException, CardRequestTimeoutException, CardConnectionException</span><br><span> from smartcard.System import readers</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-from pySim.exceptions import NoCardError</span><br><span style="color: hsl(120, 100%, 40%);">+from pySim.exceptions import NoCardError, ProtocolError</span><br><span> from pySim.transport import LinkBase</span><br><span> from pySim.utils import h2i, i2h</span><br><span> </span><br><span>diff --git a/pySim/utils.py b/pySim/utils.py</span><br><span>index c5cf480..f7d099b 100644</span><br><span>--- a/pySim/utils.py</span><br><span>+++ b/pySim/utils.py</span><br><span>@@ -249,7 +249,7 @@</span><br><span>        """</span><br><span>   Calculate Luhn checksum used in e.g. ICCID and IMEI</span><br><span>  """</span><br><span style="color: hsl(0, 100%, 40%);">-      num = map(int, str(cc))</span><br><span style="color: hsl(120, 100%, 40%);">+       num = list(map(int, str(cc)))</span><br><span>        check_digit = 10 - sum(num[-2::-2] + [sum(divmod(d * 2, 10)) for d in num[::-2]]) % 10</span><br><span>       return 0 if check_digit == 10 else check_digit</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/20762">change 20762</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/20762"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iff4123a49c8dbcfc405612c0663d5c7d0f549748 </div>
<div style="display:none"> Gerrit-Change-Number: 20762 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>