<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20696">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler: drop meaningless check in trx_sched_set_lchan()<br><br>Both TRXC_PDTCH or TRXC_PTCCH are described in 'trx_chan_desc'<br>(defined as 'const'), and both have TRX_CHAN_FLAG_PDCH set. So<br>indeed, this condition can never be true.<br><br>Change-Id: Ie185a939b48eb859ac1c8ffa0a4f667fda0cb82b<br>---<br>M src/common/scheduler.c<br>1 file changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/96/20696/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index 5d46a25..ed41f9d 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -983,11 +983,6 @@</span><br><span>       for (i = 0; i < _TRX_CHAN_MAX; i++) {</span><br><span>             struct l1sched_chan_state *chan_state;</span><br><span>               chan_state = &l1ts->chan_state[i];</span><br><span style="color: hsl(0, 100%, 40%);">-               /* Skip if pchan type does not match pdch flag.</span><br><span style="color: hsl(0, 100%, 40%);">-          * FIXME: Is it possible at all? Clarify if so. */</span><br><span style="color: hsl(0, 100%, 40%);">-              if ((trx_sched_multiframes[l1ts->mf_index].pchan == GSM_PCHAN_PDCH)</span><br><span style="color: hsl(0, 100%, 40%);">-              && !(trx_chan_desc[i].flags & TRX_CHAN_FLAG_PDCH))</span><br><span style="color: hsl(0, 100%, 40%);">-                      continue;</span><br><span>            if (trx_chan_desc[i].chan_nr == (chan_nr & RSL_CHAN_NR_MASK)</span><br><span>              && trx_chan_desc[i].link_id == link_id) {</span><br><span>                   rc = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20696">change 20696</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20696"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie185a939b48eb859ac1c8ffa0a4f667fda0cb82b </div>
<div style="display:none"> Gerrit-Change-Number: 20696 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>