<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20678">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: Fix race condition during init_rsl receiving from multiple TRX<br><br>When several TRX are set up, it can be that in between a RSLEM_EV_TRX_UP<br>event and the related tr_RSL_RF_RES_IND for that TRX, we receive a<br>RSLEM_EV_TRX_UP from another TRX which got just connected in parallel.<br><br>Change-Id: I1296c76c1d97e6704340484994ff3921975146b9<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 20 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/20678/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 0ce611a..ae2d2e0 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -194,8 +194,11 @@</span><br><span> </span><br><span> private function f_init_rsl(charstring id) runs on test_CT {</span><br><span>   var bitstring trx_mask := '00000000'B;</span><br><span style="color: hsl(120, 100%, 40%);">+        var bitstring rfind_mask := '00000000'B;</span><br><span>     var integer trx_count := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+   var integer rfind_count := 0;</span><br><span>        var RSLEm_Event ev;</span><br><span style="color: hsl(120, 100%, 40%);">+   var ASP_RSL_Unitdata rx_ud;</span><br><span>  timer T;</span><br><span> </span><br><span>         vc_IPA := IPA_Emulation_CT.create(id & "-RSL-IPA");</span><br><span>@@ -220,14 +223,28 @@</span><br><span>                            log2str("Duplicate RSL stream ID (", ev.sid, ")"));</span><br><span>              }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* This message (RF RESource INDication) is sent by the IUT itself */</span><br><span style="color: hsl(0, 100%, 40%);">-           RSL_CCHAN.receive(tr_ASP_RSL_UD(tr_RSL_RF_RES_IND, ev.sid));</span><br><span>                 trx_mask[enum2int(ev.sid)] := '1'B;</span><br><span>          trx_count := trx_count + 1;</span><br><span> </span><br><span>              log(trx_count, "/", mp_transceiver_num, " transceiver(s) connected");</span><br><span style="color: hsl(0, 100%, 40%);">-               if (trx_count < mp_transceiver_num) { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+            repeat;</span><br><span>              }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* This message (RF RESource INDication) is sent by the IUT itself */</span><br><span style="color: hsl(120, 100%, 40%);">+ [] RSL_CCHAN.receive(tr_ASP_RSL_UD(tr_RSL_RF_RES_IND, ?)) -> value rx_ud {</span><br><span style="color: hsl(120, 100%, 40%);">+         if (trx_mask[enum2int(rx_ud.streamId)] == '0'B) {</span><br><span style="color: hsl(120, 100%, 40%);">+                     Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,</span><br><span style="color: hsl(120, 100%, 40%);">+                            log2str("Got RF Resource Indication before RSLEM_EV_TRX_UP (", rx_ud.streamId, ")"));</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+             if (rfind_mask[enum2int(rx_ud.streamId)] == '1'B) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,</span><br><span style="color: hsl(120, 100%, 40%);">+                            log2str("Duplicate RF Resource Indication ID (", rx_ud.streamId, ")"));</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           rfind_mask[enum2int(rx_ud.streamId)] := '1'B;</span><br><span style="color: hsl(120, 100%, 40%);">+         rfind_count := rfind_count + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+               log(rfind_count, "/", mp_transceiver_num, " RF Resource Indication(s) received");</span><br><span style="color: hsl(120, 100%, 40%);">+         if (rfind_count < mp_transceiver_num) { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span>    /* osmo-bts may send us CCCH LOAD INDication or whatever else */</span><br><span>     [] RSL_CCHAN.receive(ASP_RSL_Unitdata:?) { repeat; }</span><br><span>         [] T.timeout {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20678">change 20678</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20678"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1296c76c1d97e6704340484994ff3921975146b9 </div>
<div style="display:none"> Gerrit-Change-Number: 20678 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>