<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20581">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  neels: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gad.c: try to workaround warning for "h.type >= 0"<br><br>The DEC_ERR() macro has a check for a missing type, but when used on the uint<br>h.type variable, emits a warning about an always-true statement. Try to work<br>around that warning with a cast to (int).<br><br>Related: CID#214888 CID#214890 CID#214891<br>Change-Id: Ic5fa87d23a6f0ce872de9c1dcfe36023981f70de<br>---<br>M src/gsm/gad.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gad.c b/src/gsm/gad.c</span><br><span>index 3ec28f9..f7ee48a 100644</span><br><span>--- a/src/gsm/gad.c</span><br><span>+++ b/src/gsm/gad.c</span><br><span>@@ -252,8 +252,8 @@</span><br><span>                          .rc = (RC), \</span><br><span>                                .type = (TYPE), \</span><br><span>                            .logmsg = talloc_asprintf(*err, "Error decoding GAD%s%s: " fmt, \</span><br><span style="color: hsl(0, 100%, 40%);">-                                                       (TYPE) >= 0 ? " " : "", \</span><br><span style="color: hsl(0, 100%, 40%);">-                                                        (TYPE) >= 0 ? osmo_gad_type_name(TYPE) : "", ##args), \</span><br><span style="color: hsl(120, 100%, 40%);">+                                                          ((int)(TYPE)) >= 0 ? " " : "", \</span><br><span style="color: hsl(120, 100%, 40%);">+                                                       ((int)(TYPE)) >= 0 ? osmo_gad_type_name(TYPE) : "", ##args), \</span><br><span>                        }; \</span><br><span>                 } \</span><br><span>          return RC; \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20581">change 20581</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20581"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic5fa87d23a6f0ce872de9c1dcfe36023981f70de </div>
<div style="display:none"> Gerrit-Change-Number: 20581 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>