<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-netif/+/20643">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">examples: Use osmo_stream_*_set_nodelay in ipa examples<br><br>We have functions to help with/abstract the nodelay settings so use<br>those.<br><br>Change-Id: Icb143c6e5fc3063f942a744deb576865674a4c62<br>---<br>M examples/ipa-stream-client.c<br>M examples/ipa-stream-server.c<br>2 files changed, 2 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/43/20643/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c</span><br><span>index ec7d2b3..0c9c589 100644</span><br><span>--- a/examples/ipa-stream-client.c</span><br><span>+++ b/examples/ipa-stream-client.c</span><br><span>@@ -186,21 +186,13 @@</span><br><span>      osmo_stream_cli_set_disconnect_cb(conn, disconnect_cb);</span><br><span>      osmo_stream_cli_set_read_cb(conn, read_cb);</span><br><span>  osmo_stream_cli_set_data(conn, &num_msgs);</span><br><span style="color: hsl(120, 100%, 40%);">+        osmo_stream_cli_set_nodelay(conn, true);</span><br><span> </span><br><span>         if (osmo_stream_cli_open(conn) < 0) {</span><br><span>             fprintf(stderr, "cannot open client\n");</span><br><span>           exit(EXIT_FAILURE);</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   int on = 1, ret;</span><br><span style="color: hsl(0, 100%, 40%);">-        struct osmo_fd *ofd = osmo_stream_cli_get_ofd(conn);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-    ret = setsockopt(ofd->fd, IPPROTO_TCP, TCP_NODELAY, &on, sizeof(on));</span><br><span style="color: hsl(0, 100%, 40%);">-    if (ret < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DIPATEST, LOGL_ERROR, "cannot disable Nagle\n");</span><br><span style="color: hsl(0, 100%, 40%);">-         exit(EXIT_FAILURE);</span><br><span style="color: hsl(0, 100%, 40%);">-     }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    LOGP(DIPATEST, LOGL_NOTICE, "Entering main loop\n");</span><br><span> </span><br><span>   while(1) {</span><br><span>diff --git a/examples/ipa-stream-server.c b/examples/ipa-stream-server.c</span><br><span>index e774b31..c311697 100644</span><br><span>--- a/examples/ipa-stream-server.c</span><br><span>+++ b/examples/ipa-stream-server.c</span><br><span>@@ -117,21 +117,13 @@</span><br><span>      osmo_stream_srv_link_set_addr(srv, "127.0.0.1");</span><br><span>   osmo_stream_srv_link_set_port(srv, 10000);</span><br><span>   osmo_stream_srv_link_set_accept_cb(srv, accept_cb);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-     int on = 1, ret;</span><br><span style="color: hsl(0, 100%, 40%);">-        struct osmo_fd *ofd = osmo_stream_srv_link_get_ofd(srv);</span><br><span style="color: hsl(120, 100%, 40%);">+      osmo_stream_srv_link_set_nodelay(srv, true);</span><br><span> </span><br><span>     if (osmo_stream_srv_link_open(srv) < 0) {</span><br><span>                 fprintf(stderr, "cannot open client\n");</span><br><span>           exit(EXIT_FAILURE);</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   ret = setsockopt(ofd->fd, IPPROTO_TCP, TCP_NODELAY, &on, sizeof(on));</span><br><span style="color: hsl(0, 100%, 40%);">-    if (ret < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DSTREAMTEST, LOGL_ERROR, "cannot disable Nagle\n");</span><br><span style="color: hsl(0, 100%, 40%);">-              exit(EXIT_FAILURE);</span><br><span style="color: hsl(0, 100%, 40%);">-     }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    LOGP(DSTREAMTEST, LOGL_NOTICE, "Entering main loop\n");</span><br><span> </span><br><span>        while(1) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-netif/+/20643">change 20643</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-netif/+/20643"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-netif </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icb143c6e5fc3063f942a744deb576865674a4c62 </div>
<div style="display:none"> Gerrit-Change-Number: 20643 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>