<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20645">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: fix CHANnel ACTIVation message in TC_meas_res_sign_tchX<br><br>The testcase TC_meas_res_sign_tchX activates a traffic channel in<br>signalling mode and checks the RSL resulting measurement reports.<br><br>The CHANnel ACTIVation message sets "SDCCH" as "Channel rate and Type"<br>value. This is invalid, the "Channel Rate and Type" sould be set to "Half /<br>Full rate TCH Channel Lm / Bm" (while the speech or data indicator is<br>still set to "Signalling")<br><br>Change-Id: I51887b0d0379fcc1f4483d08dfdd6869e7a9f963<br>Related: OS#4799<br>---<br>M bts/BTS_Tests.ttcn<br>M library/RSL_Types.ttcn<br>2 files changed, 10 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/20645/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 221c33e..4617b5d 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -2916,7 +2916,8 @@</span><br><span> var ConnHdlrPars pars;</span><br><span> f_init();</span><br><span> for (var integer tn := 1; tn <= 4; tn := tn+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- pars := valueof(t_Pars(t_RslChanNr_Bm(tn), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(t_RslChanNr_Bm(tn),</span><br><span style="color: hsl(120, 100%, 40%);">+ ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_NO_RESOURCE, false, RSL_SPDI_SIGN)));</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars,</span><br><span> pcu_comp := false, trxc_comp := true);</span><br><span> vc_conn.done;</span><br><span>@@ -2928,7 +2929,8 @@</span><br><span> var ConnHdlrPars pars;</span><br><span> f_init();</span><br><span> for (var integer ss := 0; ss <= 1; ss := ss+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss),</span><br><span style="color: hsl(120, 100%, 40%);">+ ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_NO_RESOURCE, false, RSL_SPDI_SIGN)));</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars,</span><br><span> pcu_comp := false, trxc_comp := true);</span><br><span> vc_conn.done;</span><br><span>@@ -2965,7 +2967,8 @@</span><br><span> f_init();</span><br><span> f_vty_config(BTSVTY, "bts 0", "supp-meas-info toa256");</span><br><span> for (var integer ss := 0; ss <= 1; ss := ss+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss),</span><br><span style="color: hsl(120, 100%, 40%);">+ ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_NO_RESOURCE, false, RSL_SPDI_SIGN)));</span><br><span> pars.l1_pars.toa256_enabled := true;</span><br><span> vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars);</span><br><span> vc_conn.done;</span><br><span>diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn</span><br><span>index 05effa2..65ed93c 100644</span><br><span>--- a/library/RSL_Types.ttcn</span><br><span>+++ b/library/RSL_Types.ttcn</span><br><span>@@ -408,15 +408,17 @@</span><br><span> }</span><br><span> </span><br><span> template (value) RSL_IE_ChannelMode ts_RSL_ChanMode(RSL_ChanRateType t, RSL_SpeechAlgo alg,</span><br><span style="color: hsl(0, 100%, 40%);">- boolean dtx_downlink := false) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean dtx_downlink := false,</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL_SpeechDataInd spd_ind := RSL_SPDI_SPEECH) := {</span><br><span> len := 0, /* overwritten */</span><br><span> reserved := '000000'B,</span><br><span> dtx_d := dtx_downlink,</span><br><span> dtx_u := false,</span><br><span style="color: hsl(0, 100%, 40%);">- spd_ind := RSL_SPDI_SPEECH,</span><br><span style="color: hsl(120, 100%, 40%);">+ spd_ind := spd_ind,</span><br><span> ch_rate_type := t,</span><br><span> coding_alg_rate := alg</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> template RSL_IE_ChannelMode tr_RSL_ChanMode(template RSL_ChanRateType t,</span><br><span> template RSL_SpeechAlgo alg) := {</span><br><span> len := ?,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20645">change 20645</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20645"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I51887b0d0379fcc1f4483d08dfdd6869e7a9f963 </div>
<div style="display:none"> Gerrit-Change-Number: 20645 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>