<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20575">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Set TCP_NODELAY on VTY sockets<br><br>VTY is an interactive console over telnet, so for sure we want to<br>disable Nagle algorithm there so make interaction as quick as possible.<br><br>Related: OS#4499<br>Change-Id: I34f8d3ac70045e48613f67e3c79c2ff49c4d2794<br>---<br>M src/vty/telnet_interface.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/20575/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c</span><br><span>index cd32e68..a25070b 100644</span><br><span>--- a/src/vty/telnet_interface.c</span><br><span>+++ b/src/vty/telnet_interface.c</span><br><span>@@ -22,6 +22,7 @@</span><br><span> </span><br><span> #include <sys/socket.h></span><br><span> #include <netinet/in.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <netinet/tcp.h></span><br><span> #include <errno.h></span><br><span> #include <stdlib.h></span><br><span> #include <stdio.h></span><br><span>@@ -101,6 +102,11 @@</span><br><span>           return -1;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ rc = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+       rc = setsockopt(server_socket.fd, IPPROTO_TCP, TCP_NODELAY, &rc, sizeof(rc));</span><br><span style="color: hsl(120, 100%, 40%);">+     if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLGLOBAL, LOGL_ERROR, "Failed to set TCP_NODELAY on VTY socket: %s\n", strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    LOGP(DLGLOBAL, LOGL_NOTICE, "Available via telnet %s %d\n", ip, port);</span><br><span>     return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20575">change 20575</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20575"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I34f8d3ac70045e48613f67e3c79c2ff49c4d2794 </div>
<div style="display:none"> Gerrit-Change-Number: 20575 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>