<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20555">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: add gprs_ns2_free_binds() to free all binds<br><br>Allow users to clean up all binds (e.g. the PCU).<br><br>Change-Id: Ic8f6f8aca10da23a18fab8870be7806065a34b47<br>---<br>M include/osmocom/gprs/gprs_ns2.h<br>M src/gb/gprs_ns2.c<br>M src/gb/libosmogb.map<br>3 files changed, 12 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/20555/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h</span><br><span>index d798ac4..2c58723 100644</span><br><span>--- a/include/osmocom/gprs/gprs_ns2.h</span><br><span>+++ b/include/osmocom/gprs/gprs_ns2.h</span><br><span>@@ -131,6 +131,7 @@</span><br><span>                                      uint16_t nsvci);</span><br><span> </span><br><span> void gprs_ns2_free_bind(struct gprs_ns2_vc_bind *bind);</span><br><span style="color: hsl(120, 100%, 40%);">+void gprs_ns2_free_binds(struct gprs_ns2_inst *nsi);</span><br><span> </span><br><span> /* create a VC SNS connection */</span><br><span> int gprs_ns2_ip_connect_sns(struct gprs_ns2_vc_bind *bind,</span><br><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index 9f9d1cc..20e4473 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -997,7 +997,6 @@</span><br><span>  *  \param[in] nsi NS instance to destroy */</span><br><span> void gprs_ns2_free(struct gprs_ns2_inst *nsi)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        struct gprs_ns2_vc_bind *bind, *tbind;</span><br><span>       struct gprs_ns2_nse *nse, *ntmp;</span><br><span> </span><br><span>         if (!nsi)</span><br><span>@@ -1007,9 +1006,7 @@</span><br><span>            gprs_ns2_free_nse(nse);</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   llist_for_each_entry_safe(bind, tbind, &nsi->binding, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-            gprs_ns2_free_bind(bind);</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(120, 100%, 40%);">+     gprs_ns2_free_binds(nsi);</span><br><span> </span><br><span>        talloc_free(nsi);</span><br><span> }</span><br><span>@@ -1067,4 +1064,13 @@</span><br><span>      llist_del(&bind->list);</span><br><span>       talloc_free(bind);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void gprs_ns2_free_binds(struct gprs_ns2_inst *nsi)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     struct gprs_ns2_vc_bind *bind, *tbind;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      llist_for_each_entry_safe(bind, tbind, &nsi->binding, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+          gprs_ns2_free_bind(bind);</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> /*! @} */</span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index 3d1d5d6..d23d263 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -79,6 +79,7 @@</span><br><span> gprs_ns2_find_vc_by_sockaddr;</span><br><span> gprs_ns2_free;</span><br><span> gprs_ns2_free_bind;</span><br><span style="color: hsl(120, 100%, 40%);">+gprs_ns2_free_binds;</span><br><span> gprs_ns2_free_nse;</span><br><span> gprs_ns2_free_nsvc;</span><br><span> gprs_ns2_frgre_bind;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20555">change 20555</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20555"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic8f6f8aca10da23a18fab8870be7806065a34b47 </div>
<div style="display:none"> Gerrit-Change-Number: 20555 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>