<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20573">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Fix left shifting out of range on signed variable<br><br>Fixes following ASan runtime errors while running vty tests:<br>src/vty/command.c:3088:27: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'<br>src/vty/command.c:3136:23: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'<br><br>Change-Id: Ie11ff18d6fd9f6e1e91a51b6156fb6b0b7d3a9a8<br>---<br>M src/vty/command.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index fae925e..d8649f5 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -3085,7 +3085,7 @@</span><br><span>                          continue;</span><br><span>                    if (cmd->attr & (CMD_ATTR_DEPRECATED | CMD_ATTR_HIDDEN))</span><br><span>                              continue;</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (~cmd->usrattr & (1 << f))</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (~cmd->usrattr & ((unsigned)1 << f))</span><br><span>                                 continue;</span><br><span> </span><br><span>                        if (cmd->attr & CMD_ATTR_LIB_COMMAND)</span><br><span>@@ -3133,9 +3133,9 @@</span><br><span>         unsigned int f;</span><br><span> </span><br><span>  for (f = 0; f < VTY_CMD_USR_ATTR_NUM; f++) {</span><br><span style="color: hsl(0, 100%, 40%);">-         if (~flag_mask & (1 << f))</span><br><span style="color: hsl(120, 100%, 40%);">+          if (~flag_mask & ((unsigned)1 << f))</span><br><span>                       continue;</span><br><span style="color: hsl(0, 100%, 40%);">-               if (~cmd->usrattr & (1 << f)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          if (~cmd->usrattr & ((unsigned)1 << f)) {</span><br><span>                       *(ptr++) = '.';</span><br><span>                      continue;</span><br><span>            }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20573">change 20573</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20573"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie11ff18d6fd9f6e1e91a51b6156fb6b0b7d3a9a8 </div>
<div style="display:none"> Gerrit-Change-Number: 20573 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>