<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20539">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: Avoid race condition in  TC_pcu_deact_req<br><br>When our emulated PCU sends a DEACT.req to the BTS, there is no way<br>of knowing when exactly that command will have been completed: There is<br>no confirmation sent in response.<br><br>Let's introduce a f_sleep(1.0) to give the BTS sufficient time for<br>deactivating the channel.<br><br>This will make  TC_pcu_deact_req pass reliably.  It currently fails<br>in about one third of all test executions on jenkins.<br><br>Change-Id: Id9a559b8b208a60f71c3eb9a23830e4d2dbc5df9<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/20539/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 221c33e..95d0dab 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -4364,7 +4364,9 @@</span><br><span> </span><br><span>  /* Send PDCH activate request for known PDCH timeslot */</span><br><span>     PCU.send(t_SD_PCUIF(g_pcu_conn_id, ts_PCUIF_DEACT_REQ(bts_nr, trx_nr, ts_nr)));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+       /* wait for some time as there is no PCUIF_DEACT_RESP or the like, so we don't know</span><br><span style="color: hsl(120, 100%, 40%);">+        * when it will actually have been executed in the BTS */</span><br><span style="color: hsl(120, 100%, 40%);">+     f_sleep(1.0);</span><br><span>        PCU.clear;</span><br><span>   /* we now expect no RTS.req for this timeslot */</span><br><span>     T.start;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20539">change 20539</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20539"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id9a559b8b208a60f71c3eb9a23830e4d2dbc5df9 </div>
<div style="display:none"> Gerrit-Change-Number: 20539 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>